rtcp::Pli moved into own file and got a Parse function

rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold common data for Feedback Message.

BUG=webrtc:5260
Committed: https://crrev.com/f8385aded0943c7889d6e9b92f3c0978f3657bb2
Cr-Commit-Position: refs/heads/master@{#10823}

[danilchap, 2015-11-13 17:46:58]

Description was changed from

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class betweeb rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.
==========

to

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.
==========

[danilchap, 2015-11-13 17:46:58]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[sprang_webrtc, 2015-11-16 10:01:34]

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:40: const Pli& parsed
= mutable_parsed;  // Read values from constant object.
Why not use mutable_parsed directly?

[danilchap, 2015-11-16 11:03:59]

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:40: const Pli& parsed
= mutable_parsed;  // Read values from constant object.
On 2015/11/16 10:01:34, språng wrote:
> Why not use mutable_parsed directly?

It is a check that accessors are const
(this kind of test helped me to find few places where I forgot to put const on
accessor)

[åsapersson, 2015-11-25 16:14:49]

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:57:
TEST(RtcpPacketPliTest, ParseFailesOnSmallPacket) {
maybe ParseFailsOnTooSmallPacket

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:65: EXPECT_TRUE(
maybe use kPacket (if create already tested)

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:14: #include
"webrtc/base/logging.h"
remove unused

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:18: using
webrtc::RTCPUtility::RtcpCommonHeader;
remove unused

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:44: void
Psfb::CreateBaseFeedback(uint8_t* payload) const {
buffer in h.file

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h:36: static const size_t
kFeedbackLength = 8;
maybe kCommonFeedbackLength

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h:38: void
CreateBaseFeedback(uint8_t* buffer) const;
maybe Parse/CreateCommonFeedback

[danilchap, 2015-11-25 16:49:17]

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:57:
TEST(RtcpPacketPliTest, ParseFailesOnSmallPacket) {
On 2015/11/25 16:14:48, åsapersson wrote:
> maybe ParseFailsOnTooSmallPacket

Done.

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:65: EXPECT_TRUE(
On 2015/11/25 16:14:48, åsapersson wrote:
> maybe use kPacket (if create already tested)

Done.

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:14: #include
"webrtc/base/logging.h"
On 2015/11/25 16:14:48, åsapersson wrote:
> remove unused

Done.

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:18: using
webrtc::RTCPUtility::RtcpCommonHeader;
On 2015/11/25 16:14:48, åsapersson wrote:
> remove unused

Done.

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc:44: void
Psfb::CreateBaseFeedback(uint8_t* payload) const {
On 2015/11/25 16:14:48, åsapersson wrote:
> buffer in h.file

Done. (changed the name in the .h to match Parse function)

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h (right):

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h:36: static const size_t
kFeedbackLength = 8;
On 2015/11/25 16:14:48, åsapersson wrote:
> maybe kCommonFeedbackLength

Done.

https://codereview.webrtc.org/1446513002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h:38: void
CreateBaseFeedback(uint8_t* buffer) const;
On 2015/11/25 16:14:48, åsapersson wrote:
> maybe Parse/CreateCommonFeedback

Done.

[åsapersson, 2015-11-26 08:24:36]

lgtm

https://codereview.webrtc.org/1446513002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:55:
TEST(RtcpPacketPliTest, ParseFailesOnTooSmallPacket) {
Failes->Fails

[danilchap, 2015-11-26 23:05:34]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-11-26 23:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1446513002/#ps40001 (title:
"merged with master")

[commit-bot: I haz the power, 2015-11-26 23:05:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446513002/40001

[danilchap, 2015-11-26 23:05:46]

https://codereview.webrtc.org/1446513002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc (right):

https://codereview.webrtc.org/1446513002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc:55:
TEST(RtcpPacketPliTest, ParseFailesOnTooSmallPacket) {
On 2015/11/26 08:24:36, åsapersson wrote:
> Failes->Fails

Done.

[danilchap, 2015-11-26 23:09:33]

Description was changed from

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.
==========

to

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.

BUG=webrtc:5260
==========

[commit-bot: I haz the power, 2015-11-27 01:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 01:05:56]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[danilchap, 2015-11-27 12:38:57]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2015-11-27 12:39:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446513002/40001

[commit-bot: I haz the power, 2015-11-27 13:36:15]

Description was changed from

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.

BUG=webrtc:5260
==========

to

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.

BUG=webrtc:5260
==========

[commit-bot: I haz the power, 2015-11-27 13:36:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 13:36:24]

Description was changed from

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.

BUG=webrtc:5260
==========

to

==========
rtcp::Pli moved into own file and got a Parse function
Created rtcp::Psfb abstract class between rtcp::Pli and rtcp::RtcpPacket to hold
common data for Feedback Message.

BUG=webrtc:5260

Committed: https://crrev.com/f8385aded0943c7889d6e9b92f3c0978f3657bb2
Cr-Commit-Position: refs/heads/master@{#10823}
==========

[commit-bot: I haz the power, 2015-11-27 13:36:25]

Patchset 3 (id:??) landed as
https://crrev.com/f8385aded0943c7889d6e9b92f3c0978f3657bb2
Cr-Commit-Position: refs/heads/master@{#10823}