Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1446093003: Adding stddef.h to opus_inst.h. (Closed)

Created:
5 years, 1 month ago by minyue-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding stddef.h to opus_inst.h. This is to prevent size_t from undefined. This does not happen in current WebRTC since the sources that opus_inst.h gets used have proper definitions. But it would be good to add the definition in itself. Committed: https://crrev.com/9a7c838ec419fcef29e40e6089acc90406181644 Cr-Commit-Position: refs/heads/master@{#10653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_inst.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
minyue-webrtc
Hi Karl, Would you review this?
5 years, 1 month ago (2015-11-16 14:21:48 UTC) #3
kwiberg-webrtc
lgtm
5 years, 1 month ago (2015-11-16 14:25:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446093003/1
5 years, 1 month ago (2015-11-16 14:25:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 16:07:05 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:07:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a7c838ec419fcef29e40e6089acc90406181644
Cr-Commit-Position: refs/heads/master@{#10653}

Powered by Google App Engine
This is Rietveld 408576698