ThreadUtils: Add joinUninterruptibly() with timeout

ThreadUtils: Add joinUninterruptibly() with timeout

This is similar to com.google.common.util.concurrent.Uninterruptibles.joinUninterruptibly().
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/Uninterruptibles.html#joinUninterruptibly(java.lang.Thread,%20long,%20java.util.concurrent.TimeUnit)

Committed: https://crrev.com/633a3aa26fbe9dc40df880ba4ffa7b863f11e473
Cr-Commit-Position: refs/heads/master@{#10651}

[magjed_webrtc, 2015-11-16 09:51:37]

Description was changed from

==========
ThreadUtils: Add joinUninterruptibly() with timeout

This is similar to
com.google.common.util.concurrent.Uninterruptibles.joinUninterruptibly().
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util...
==========

to

==========
ThreadUtils: Add joinUninterruptibly() with timeout

This is similar to
com.google.common.util.concurrent.Uninterruptibles.joinUninterruptibly().
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util...
==========

[magjed_webrtc, 2015-11-16 09:51:37]

magjed@webrtc.org changed reviewers:
+ henrika@webrtc.org

[magjed_webrtc, 2015-11-16 09:56:22]

henrika - Please take a look. I think you want to use this function in
WebRtcAudioRecord.joinThread() with something like this:
public void joinThread() {
  keepAlive = false;
  if (!ThreadUtils.joinUninterruptibly(this, 1000)) {
    Logging.e(TAG, "Timeout in WebRtcAudioRecord.joinThread()");
  }
}

[henrika_webrtc, 2015-11-16 09:59:36]

Thanks! 

LGTM

[henrika_webrtc, 2015-11-16 10:00:27]

https://codereview.webrtc.org/1444273002/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/1444273002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:91: public static
boolean joinUninterruptibly(final Thread thread, long timeoutMs) {
Nit, above 80?

[magjed_webrtc, 2015-11-16 12:12:14]

https://codereview.webrtc.org/1444273002/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/1444273002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:91: public static
boolean joinUninterruptibly(final Thread thread, long timeoutMs) {
On 2015/11/16 10:00:27, henrika_webrtc wrote:
> Nit, above 80?

Yes, but the limit is 100 for java files.

[magjed_webrtc, 2015-11-16 12:12:31]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2015-11-16 12:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1444273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1444273002/20001

[commit-bot: I haz the power, 2015-11-16 13:12:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-16 13:12:45]

Patchset 2 (id:??) landed as
https://crrev.com/633a3aa26fbe9dc40df880ba4ffa7b863f11e473
Cr-Commit-Position: refs/heads/master@{#10651}