Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 1443613002: Remove scoped_ptrs for VCM sender_ and receiver_. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove scoped_ptrs for VCM sender_ and receiver_. Put VideoSender/VideoReceiver flat within the object, not as scoped_ptrs, giving fewer allocations and looking a bit nicer. BUG= R=tommi@webrtc.org Committed: https://crrev.com/0fa9b2278997b227042eaf6a6eae518a4b78f1ce Cr-Commit-Position: refs/heads/master@{#10634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -64 lines) Patch
M webrtc/modules/video_coding/main/source/video_coding_impl.cc View 3 chunks +57 lines, -64 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pbos-webrtc
PTAL, your TODO -> your review. :)
5 years, 1 month ago (2015-11-13 11:41:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443613002/1
5 years, 1 month ago (2015-11-13 11:41:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 12:59:52 UTC) #8
tommi
lgtm, thanks!
5 years, 1 month ago (2015-11-13 13:58:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443613002/1
5 years, 1 month ago (2015-11-13 13:58:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 14:00:00 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 14:00:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fa9b2278997b227042eaf6a6eae518a4b78f1ce
Cr-Commit-Position: refs/heads/master@{#10634}

Powered by Google App Engine
This is Rietveld 408576698