Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1443273002: cleanup: get rid of basicdefs.h include (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
juberti1, tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

cleanup: get rid of basicdefs.h include The ARRAY_SIZE macro it defines is not used anymore, as all the usages were converted to arraysize macro from arraysize.h. BUG=None R=tommi@webrtc.org Committed: https://crrev.com/fa5d0dbd1e4de062d105b065fc2e40da47ef827a Cr-Commit-Position: refs/heads/master@{#10640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/crc32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmppclient.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmppsocket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportdescription.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/client/httpportallocator.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL.
5 years, 1 month ago (2015-11-13 21:46:07 UTC) #1
tommi
lgtm
5 years, 1 month ago (2015-11-13 21:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443273002/1
5 years, 1 month ago (2015-11-13 21:56:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 22:37:43 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 22:37:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa5d0dbd1e4de062d105b065fc2e40da47ef827a
Cr-Commit-Position: refs/heads/master@{#10640}

Powered by Google App Engine
This is Rietveld 408576698