Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1442863003: Revert of Remove global list of SRTP sessions. (Closed)

Created:
5 years, 1 month ago by phoglund
Modified:
5 years, 1 month ago
Reviewers:
joachim, juberti1, juberti
CC:
webrtc-reviews_webrtc.org, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove global list of SRTP sessions. (patchset #4 id:60001 of https://codereview.webrtc.org/1416093010/ ) Reason for revert: Unfortunately this breaks an internal downstream project since we have an ancient libsrtp. Reverting until we can figure out how to update our libsrtp. Original issue's description: > Remove global list of SRTP sessions. > Instead save a reference to the SrtpSession inside the srtp_ctx_t. > > BUG=webrtc:5133 > > Committed: https://crrev.com/9cafd972779ed7b25886ab276e0ede7b7a8b76a1 > Cr-Commit-Position: refs/heads/master@{#10591} TBR=juberti@google.com,juberti@webrtc.org,jbauch@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5133 Committed: https://crrev.com/cbe9f51cf85a5aeb20a5134dad56cd2b527c098d Cr-Commit-Position: refs/heads/master@{#10635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M talk/session/media/srtpfilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/session/media/srtpfilter.cc View 12 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund
Created Revert of Remove global list of SRTP sessions.
5 years, 1 month ago (2015-11-13 14:54:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442863003/1
5 years, 1 month ago (2015-11-13 14:55:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 14:55:14 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 14:55:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbe9f51cf85a5aeb20a5134dad56cd2b527c098d
Cr-Commit-Position: refs/heads/master@{#10635}

Powered by Google App Engine
This is Rietveld 408576698