Converted a bunch of error checking in Audio[Receive|Send]Stream to RTC_CHECKs instead. They should…

Converted a bunch of error checking in Audio[Receive|Send]Stream to RTC_CHECKs instead. They should never fail.

BUG=webrtc:4690
Committed: https://crrev.com/8b85de2ba1a8885b70bf9fe8beadc54c5c405335
Cr-Commit-Position: refs/heads/master@{#10654}

[the sun, 2015-11-12 15:18:35]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2015-11-12 16:24:43]

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
File webrtc/audio/audio_send_stream.cc (right):

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:127: // TODO(ajm): Re-enable this metric once
we have a reliable implementation.
assign this to peah? (or yourself?)

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:137: RTC_CHECK_EQ(0,
rtp->GetRemoteRTCPReportBlocks(config_.voe_channel_id,
is it preferable to do this at every call site where we know that this should
never fail, or should this be done in the implementation itself? (and thus not
have to worry about the call sites and eventually change the return type to
void?)

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:158: RTC_CHECK_EQ(0,
volume->GetSpeechInputLevelFullRange(level));
same question here and I guess other places.

[the sun, 2015-11-12 16:38:17]

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
File webrtc/audio/audio_send_stream.cc (right):

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:127: // TODO(ajm): Re-enable this metric once
we have a reliable implementation.
On 2015/11/12 16:24:43, tommi (webrtc) wrote:
> assign this to peah? (or yourself?)

Done.

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:137: RTC_CHECK_EQ(0,
rtp->GetRemoteRTCPReportBlocks(config_.voe_channel_id,
On 2015/11/12 16:24:43, tommi (webrtc) wrote:
> is it preferable to do this at every call site where we know that this should
> never fail, or should this be done in the implementation itself? (and thus not
> have to worry about the call sites and eventually change the return type to
> void?)

It's a public API, used by 3rd parties. I can guarantee it will always work here
because of how the other VoE APIs are being called in WVoE/MC and the rest of
Call. We cannot make such assumptions about other users and thus can't put the
check in the implementation itself.

Soon this will be history...

https://codereview.webrtc.org/1442483003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:158: RTC_CHECK_EQ(0,
volume->GetSpeechInputLevelFullRange(level));
On 2015/11/12 16:24:43, tommi (webrtc) wrote:
> same question here and I guess other places.

Acknowledged.

[tommi, 2015-11-12 16:58:36]

lgtm

[the sun, 2015-11-16 14:59:48]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-16 14:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1442483003/#ps40001 (title:
"changed to use DCHECKs")

[commit-bot: I haz the power, 2015-11-16 14:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 14:59:55]

This CL has an open dependency (Issue 1418503010 Patch 180001). Please resolve
the dependency and try again.

[the sun, 2015-11-16 16:34:47]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-16 16:34:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1442483003/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-11-16 16:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1442483003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1442483003/80001

[commit-bot: I haz the power, 2015-11-16 17:48:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-16 17:48:20]

Patchset 5 (id:??) landed as
https://crrev.com/8b85de2ba1a8885b70bf9fe8beadc54c5c405335
Cr-Commit-Position: refs/heads/master@{#10654}