Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1442003002: Remove BitrateController dependency fromVideoReceiveStream. (Closed)

Created:
5 years, 1 month ago by mflodman
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove BitrateController dependency fromVideoReceiveStream. I have another CL moving REMB from CongestonController to Call, then I'll remove CongestoinController from this class too. R=stefan@webrtc.org Committed: https://crrev.com/0a41893e36148642d8f37fc91738e42eca47fef8 Cr-Commit-Position: refs/heads/master@{#10632}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove intra_frame_observer null check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M webrtc/video/video_receive_stream.cc View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mflodman
Stefan, Can you take a look? It's a small follow up to #10630.
5 years, 1 month ago (2015-11-13 09:27:25 UTC) #2
stefan-webrtc
lgtm https://codereview.webrtc.org/1442003002/diff/1/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1442003002/diff/1/webrtc/video_engine/vie_channel.cc#newcode125 webrtc/video_engine/vie_channel.cc:125: sender ? intra_frame_observer_ : nullptr, I think you ...
5 years, 1 month ago (2015-11-13 09:45:01 UTC) #3
mflodman
https://codereview.webrtc.org/1442003002/diff/1/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1442003002/diff/1/webrtc/video_engine/vie_channel.cc#newcode125 webrtc/video_engine/vie_channel.cc:125: sender ? intra_frame_observer_ : nullptr, On 2015/11/13 09:45:01, stefan-webrtc ...
5 years, 1 month ago (2015-11-13 10:11:58 UTC) #4
mflodman
Committed patchset #2 (id:20001) manually as 0a41893e36148642d8f37fc91738e42eca47fef8 (presubmit successful).
5 years, 1 month ago (2015-11-13 10:12:22 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 10:12:24 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a41893e36148642d8f37fc91738e42eca47fef8
Cr-Commit-Position: refs/heads/master@{#10632}

Powered by Google App Engine
This is Rietveld 408576698