Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1441693002: Rename screenshare test. (Closed)

Created:
5 years, 1 month ago by philipel
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename screenshare test. Renamed the test to reflect what is actually tested. What the old test did I don't know since there has never been possible to use screenshare with two temporal layers in VP9. BUG=chromium:554515 Committed: https://crrev.com/464c0878d915aed3ea9abc799ad08bf53791a0fd Cr-Commit-Position: refs/heads/master@{#10631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/video/full_stack.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
philipel1
5 years, 1 month ago (2015-11-12 14:11:32 UTC) #2
sprang_webrtc
lol lgtm +pbos as owner
5 years, 1 month ago (2015-11-12 14:34:20 UTC) #4
sprang_webrtc
lol lgtm +pbos as owner
5 years, 1 month ago (2015-11-12 14:34:21 UTC) #5
pbos-webrtc
A++/10, lgtm, ship it
5 years, 1 month ago (2015-11-12 14:36:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441693002/1
5 years, 1 month ago (2015-11-12 14:40:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-12 16:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441693002/1
5 years, 1 month ago (2015-11-13 10:01:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 10:08:09 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 10:08:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/464c0878d915aed3ea9abc799ad08bf53791a0fd
Cr-Commit-Position: refs/heads/master@{#10631}

Powered by Google App Engine
This is Rietveld 408576698