Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1440873005: modules/video_coding/utility: Remove include (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

modules/video_coding/utility: Remove include This makes it clearer this code not meant to be used as an API. I could not find any use of this in downstream code. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=stefan@webrtc.org TBR=magjed@webrtc.org Committed: https://crrev.com/b7ce96470b99510937e489bcb4dc3165a9ab1b28 Cr-Commit-Position: refs/heads/master@{#10699}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix after rebase mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -430 lines) Patch
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_coding/utility/frame_dropper.h View 3 chunks +8 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/utility/frame_dropper.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_coding/utility/include/frame_dropper.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/modules/video_coding/utility/include/mock/mock_frame_dropper.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/modules/video_coding/utility/include/moving_average.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/modules/video_coding/utility/include/qp_parser.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/modules/video_coding/utility/include/quality_scaler.h View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/modules/video_coding/utility/include/vp8_header_parser.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
A + webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_coding/utility/moving_average.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_coding/utility/qp_parser.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/modules/video_coding/utility/qp_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_coding/utility/quality_scaler.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 chunk +5 lines, -5 lines 0 comments Download
A + webrtc/modules/video_coding/utility/vp8_header_parser.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/utility/vp8_header_parser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-12 13:20:30 UTC) #2
stefan-webrtc
lgtm
5 years, 1 month ago (2015-11-16 17:55:22 UTC) #3
kjellander_webrtc
TBR'ing magjed@webrtc.org for talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
5 years, 1 month ago (2015-11-18 22:03:45 UTC) #7
kjellander_webrtc
Committed patchset #3 (id:40001) manually as b7ce96470b99510937e489bcb4dc3165a9ab1b28 (presubmit successful).
5 years, 1 month ago (2015-11-18 22:04:24 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:04:26 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7ce96470b99510937e489bcb4dc3165a9ab1b28
Cr-Commit-Position: refs/heads/master@{#10699}

Powered by Google App Engine
This is Rietveld 408576698