Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1440523002: Remove webrtc/modules/audio_processing/{aec,aecm,ns}/include (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/modules/audio_processing/{aec,aecm,ns}/include BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=henrik.lundin@webrtc.org Committed: https://crrev.com/9b72af94cd61782ada88f777b07854daf9657bb2 Cr-Commit-Position: refs/heads/master@{#10608}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -701 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_processing/aec/echo_cancellation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/aec/include/echo_cancellation.h View 1 chunk +0 lines, -251 lines 0 comments Download
M webrtc/modules/audio_processing/aec/system_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_c.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_mips.c View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/aecm/echo_control_mobile.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/echo_control_mobile.c View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/aecm/include/echo_control_mobile.h View 1 chunk +0 lines, -209 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_processing/ns/include/noise_suppression.h View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/modules/audio_processing/ns/include/noise_suppression_x.h View 1 chunk +0 lines, -88 lines 0 comments Download
A + webrtc/modules/audio_processing/ns/noise_suppression.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/ns/noise_suppression.c View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/ns/noise_suppression_x.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/ns/noise_suppression_x.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/ns/ns_core.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/ns/nsx_core.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/ns/nsx_core_c.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/ns/nsx_core_mips.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-11 08:56:37 UTC) #2
hlundin-webrtc
lgtm
5 years, 1 month ago (2015-11-11 15:46:47 UTC) #3
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 9b72af94cd61782ada88f777b07854daf9657bb2 (presubmit successful).
5 years, 1 month ago (2015-11-11 19:16:32 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 19:16:35 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9b72af94cd61782ada88f777b07854daf9657bb2
Cr-Commit-Position: refs/heads/master@{#10608}

Powered by Google App Engine
This is Rietveld 408576698