Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1439823002: Remove webrtc/modules/video_{capture,render}/include (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/modules/video_{capture,render}/include BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=pbos@webrtc.org, perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/5dda80abea311731144b1d544aff61c408412f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -727 lines) Patch
M talk/media/devices/mobiledevicemanager.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideocapturer.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/device_info_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_capture/include/video_capture.h View 1 chunk +0 lines, -160 lines 0 comments Download
D webrtc/modules/video_capture/include/video_capture_defines.h View 1 chunk +0 lines, -118 lines 0 comments Download
D webrtc/modules/video_capture/include/video_capture_factory.h View 1 chunk +0 lines, -45 lines 0 comments Download
M webrtc/modules/video_capture/ios/device_info_ios_objc.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_capture/video_capture.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/video_capture/video_capture_defines.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/video_capture/video_capture_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/windows/sink_filter_ds.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/android/video_render_android_native_opengl2.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/android/video_render_android_surface_view.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/android/video_render_opengles20.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/i_video_render.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_render/include/video_render.h View 1 chunk +0 lines, -268 lines 0 comments Download
D webrtc/modules/video_render/include/video_render_defines.h View 1 chunk +0 lines, -70 lines 0 comments Download
M webrtc/modules/video_render/ios/open_gles20.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/ios/video_render_ios_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/linux/video_x11_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/linux/video_x11_render.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/mac/video_render_agl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/mac/video_render_nsopengl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/test/testAPI/testAPI.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/test/testAPI/testAPI.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/test/testAPI/testAPI_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_render/video_render.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_render/video_render.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_render/video_render_defines.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_render/video_render_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_internal_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/windows/i_video_render_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/windows/video_render_direct3d9.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/vcm_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/vcm_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_capture_input.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_capture_input.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-11 22:13:11 UTC) #2
perkj_webrtc
include was the old convention we used to put header files that you were supposed ...
5 years, 1 month ago (2015-11-12 09:47:10 UTC) #3
kjellander_webrtc
+pbos for rubberstamp on webrtc/video/ + webrtc/video_engine
5 years, 1 month ago (2015-11-12 11:34:37 UTC) #5
pbos-webrtc
rs-lgtm for webrtc/{video,video_engine}.
5 years, 1 month ago (2015-11-12 11:43:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5dda80abea311731144b1d544aff61c408412f12 Cr-Commit-Position: refs/heads/master@{#10619}
5 years, 1 month ago (2015-11-12 11:47:10 UTC) #7
kjellander_webrtc
5 years, 1 month ago (2015-11-12 11:47:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5dda80abea311731144b1d544aff61c408412f12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698