[rtp_rtcp] rtcp::Sdes cleaned and got Parse function

webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d4b5f66774c58ab4efea130c067a0b03061480ef
--- /dev/null
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc
@@ -0,0 +1,128 @@
+/*
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h"
+
+#include <limits>
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
+using webrtc::rtcp::Sdes;
+
+namespace webrtc {
+namespace {
+
+const uint32_t kSenderSsrc = 0x12345678;
+
+class RtcpPacketSdesTest : public ::testing::Test {
+ protected:
+  void BuildPacket() { packet = sdes.Build().Pass(); }
+  void ParsePacket() {
+    RTCPUtility::RtcpCommonHeader header;
+    EXPECT_TRUE(RTCPUtility::RtcpParseCommonHeader(packet->Buffer(),
+                                                   packet->Length(), &header));
+    EXPECT_TRUE(header.packet_type == Sdes::kPacketType);
+    // Check that there is exactly one RTCP packet in the buffer.
+    EXPECT_EQ(header.BlockSize(), packet->Length());
+    EXPECT_TRUE(parsed_.Parse(
+        header,
+        packet->Buffer() + RTCPUtility::RtcpCommonHeader::kHeaderSizeBytes));
+  }
+
+  Sdes sdes;
+  rtc::scoped_ptr<rtcp::RawPacket> packet;
+  const Sdes& parsed() { return parsed_; }
+
+ private:
+  Sdes parsed_;
+};
+
+TEST_F(RtcpPacketSdesTest, WithOneChunk) {
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc, "alice@host"));
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(1u, parsed().chunks_count());
+  EXPECT_EQ(kSenderSsrc, parsed().chunk(0).ssrc);
+  EXPECT_EQ("alice@host", parsed().chunk(0).name);
+}
+
+TEST_F(RtcpPacketSdesTest, WithMultipleChunks) {
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc, "a"));
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc + 1, "ab"));
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc + 2, "abc"));
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc + 3, "abcd"));
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc + 4, "abcde"));
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc + 5, "abcdef"));
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(6u, parsed().chunks_count());
+  EXPECT_EQ(kSenderSsrc + 5, parsed().chunk(5).ssrc);
+  EXPECT_EQ("abcdef", parsed().chunk(5).name);
+}
+
+TEST_F(RtcpPacketSdesTest, WithTooManyChunks) {
+  const int kMaxChunks = (1 << 5) - 1;
+  for (int i = 0; i < kMaxChunks; ++i) {
+    uint32_t ssrc = kSenderSsrc + i;
+    std::ostringstream oss;
+    oss << "cname" << i;
+    EXPECT_TRUE(sdes.WithCName(ssrc, oss.str()));
+  }
+  EXPECT_FALSE(sdes.WithCName(kSenderSsrc + kMaxChunks, "foo"));
+}
+
+TEST_F(RtcpPacketSdesTest, CnameItemWithEmptyString) {
+  EXPECT_TRUE(sdes.WithCName(kSenderSsrc, ""));
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(1u, parsed().chunks_count());
+  EXPECT_EQ(kSenderSsrc, parsed().chunk(0).ssrc);
+  EXPECT_EQ("", parsed().chunk(0).name);
+}
+
+TEST_F(RtcpPacketSdesTest, SkipNonCNameField) {
+  // Current class can't build packets with anything other than CNAME,
+  // so need to assemble such a packet manually.
+  const size_t kLength = 20;
+  packet.reset(new rtcp::RawPacket(kLength));
+  packet->SetLength(kLength);
+  uint8_t* buffer = packet->MutableBuffer();
+  // Assemble header.
+  buffer[0] = (2 << 6) | 1;  // Version = 2, 1 chunk.
+  buffer[1] = Sdes::kPacketType;
+  ByteWriter<uint16_t>::WriteBigEndian(buffer + 2, (kLength / 4) - 1);
+  // Assemble the chunk.
+  ByteWriter<uint32_t>::WriteBigEndian(buffer + 4, kSenderSsrc);  // SSRC.
+  buffer[8] = 2;  // Not a CNAME field
+  buffer[9] = 3;  // of size 3.
+  buffer[10] = 'a';
+  buffer[11] = 'b';
+  buffer[12] = 'c';
+  buffer[13] = 1;  // CNAME field
+  buffer[14] = 2;  // of size 2.
+  buffer[15] = 'd';
+  buffer[16] = 'e';
+  buffer[17] = buffer[18] = buffer[19] = 0;  // Chunk padding.
+
+  ParsePacket();
+  EXPECT_EQ(1u, parsed().chunks_count());
+  EXPECT_EQ(kSenderSsrc, parsed().chunk(0).ssrc);
+  EXPECT_EQ("de", parsed().chunk(0).name);
+}
+
+}  // namespace
+}  // namespace webrtc