modules/audio_coding: Remove some codec include dirs

modules/audio_coding: Remove some codec include dirs

Also clean up some include_dir entries and update the few
references to them with absolute include paths instead.
Finally fixed a few lint errors and invalid header guards.

None of these are used downstream.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=kwiberg@webrtc.org

Committed: https://crrev.com/3c652b67468d182bd36aee4c31557621be50cc92
Cr-Commit-Position: refs/heads/master@{#10700}

[kjellander_webrtc, 2015-11-11 20:43:07]

kjellander@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, kwiberg@webrtc.org

[kjellander_webrtc, 2015-11-11 20:43:08]

kwiberg: main review
henrik.lundin: rubberstamp.

[kwiberg-webrtc, 2015-11-12 09:33:03]

On 2015/11/11 20:43:08, kjellander (webrtc) wrote:
> kwiberg: main review
> henrik.lundin: rubberstamp.

Just to confirm: This is all the files in include directories under
webrtc/modules/audio_coding, and you've moved the ones marked with "-" on elevel
up:

 webrtc/modules/audio_coding/neteq/include/neteq.h
-webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h
-webrtc/modules/audio_coding/codecs/cng/include/webrtc_cng.h
-webrtc/modules/audio_coding/codecs/g711/include/audio_encoder_pcm.h
-webrtc/modules/audio_coding/codecs/g711/include/audio_decoder_pcm.h
-webrtc/modules/audio_coding/codecs/g711/include/g711_interface.h
-webrtc/modules/audio_coding/codecs/pcm16b/include/audio_decoder_pcm16b.h
-webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h
-webrtc/modules/audio_coding/codecs/pcm16b/include/audio_encoder_pcm16b.h
-webrtc/modules/audio_coding/codecs/ilbc/include/audio_encoder_ilbc.h
-webrtc/modules/audio_coding/codecs/ilbc/include/ilbc.h
-webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h
 webrtc/modules/audio_coding/codecs/isac/fix/include/audio_decoder_isacfix.h
 webrtc/modules/audio_coding/codecs/isac/fix/include/isacfix.h
 webrtc/modules/audio_coding/codecs/isac/fix/include/audio_encoder_isacfix.h
 webrtc/modules/audio_coding/codecs/isac/main/include/isac.h
 webrtc/modules/audio_coding/codecs/isac/main/include/audio_encoder_isac.h
 webrtc/modules/audio_coding/codecs/isac/main/include/audio_decoder_isac.h
-webrtc/modules/audio_coding/codecs/opus/include/audio_encoder_opus.h
-webrtc/modules/audio_coding/codecs/opus/include/opus_interface.h
-webrtc/modules/audio_coding/codecs/opus/include/audio_decoder_opus.h
-webrtc/modules/audio_coding/codecs/g722/include/g722_interface.h
-webrtc/modules/audio_coding/codecs/g722/include/audio_decoder_g722.h
-webrtc/modules/audio_coding/codecs/g722/include/audio_encoder_g722.h
 webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h
 webrtc/modules/audio_coding/main/include/audio_coding_module.h

?

(And adjusted paths and include guards to match.)

[kjellander_webrtc, 2015-11-12 10:21:31]

On 2015/11/12 09:33:03, kwiberg-webrtc wrote:
> On 2015/11/11 20:43:08, kjellander (webrtc) wrote:
> > kwiberg: main review
> > henrik.lundin: rubberstamp.
> 
> Just to confirm: This is all the files in include directories under
> webrtc/modules/audio_coding, and you've moved the ones marked with "-" on
elevel
> up:

Yes, it's all codecs except iSAC (which will be dealt with once we've figured
out downstream usage).


> 
>  webrtc/modules/audio_coding/neteq/include/neteq.h
> -webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h
> -webrtc/modules/audio_coding/codecs/cng/include/webrtc_cng.h
> -webrtc/modules/audio_coding/codecs/g711/include/audio_encoder_pcm.h
> -webrtc/modules/audio_coding/codecs/g711/include/audio_decoder_pcm.h
> -webrtc/modules/audio_coding/codecs/g711/include/g711_interface.h
> -webrtc/modules/audio_coding/codecs/pcm16b/include/audio_decoder_pcm16b.h
> -webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h
> -webrtc/modules/audio_coding/codecs/pcm16b/include/audio_encoder_pcm16b.h
> -webrtc/modules/audio_coding/codecs/ilbc/include/audio_encoder_ilbc.h
> -webrtc/modules/audio_coding/codecs/ilbc/include/ilbc.h
> -webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h
>  webrtc/modules/audio_coding/codecs/isac/fix/include/audio_decoder_isacfix.h
>  webrtc/modules/audio_coding/codecs/isac/fix/include/isacfix.h
>  webrtc/modules/audio_coding/codecs/isac/fix/include/audio_encoder_isacfix.h
>  webrtc/modules/audio_coding/codecs/isac/main/include/isac.h
>  webrtc/modules/audio_coding/codecs/isac/main/include/audio_encoder_isac.h
>  webrtc/modules/audio_coding/codecs/isac/main/include/audio_decoder_isac.h
> -webrtc/modules/audio_coding/codecs/opus/include/audio_encoder_opus.h
> -webrtc/modules/audio_coding/codecs/opus/include/opus_interface.h
> -webrtc/modules/audio_coding/codecs/opus/include/audio_decoder_opus.h
> -webrtc/modules/audio_coding/codecs/g722/include/g722_interface.h
> -webrtc/modules/audio_coding/codecs/g722/include/audio_decoder_g722.h
> -webrtc/modules/audio_coding/codecs/g722/include/audio_encoder_g722.h
>  webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h
>  webrtc/modules/audio_coding/main/include/audio_coding_module.h
> 
> ?
> 
> (And adjusted paths and include guards to match.)

[kwiberg-webrtc, 2015-11-12 11:40:45]

lgtm

Thanks for doing this. It's good to signal that we don't want random users to
start depending on what's in those headers.

https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/ilbc/ilbc.h (right):

https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/ilbc/ilbc.h:59: *     - size              :
The size that this structure occupies (in Word16)
Note: It's easier to review if you don't include miscellaneous whitespace fixes
in parts of the code the CL has no real need to touch.

[kjellander (google.com), 2015-11-12 11:45:25]

kjellander@google.com changed reviewers:
+ kjellander@google.com

[kjellander (google.com), 2015-11-12 11:45:26]

https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/ilbc/ilbc.h (right):

https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/ilbc/ilbc.h:59: *     - size              :
The size that this structure occupies (in Word16)
On 2015/11/12 11:40:45, kwiberg-webrtc wrote:
> Note: It's easier to review if you don't include miscellaneous whitespace
fixes
> in parts of the code the CL has no real need to touch.

Yeah I know. I just couldn't resist since this was about the only one that
failed the cpplint check (which we discovered is not enabled, see
https://bugs.chromium.org/p/webrtc/issues/detail?id=5149)

[kjellander_webrtc, 2015-11-18 21:38:04]

Description was changed from

==========
Remove some codec include dirs in webrtc/modules/audio_coding

Also clean up some include_dir entries and update the few
references to them with absolute include paths instead.
Finally fixed a few lint errors and invalid header guards.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

to

==========
modules/audio_coding: Remove some codec include dirs

Also clean up some include_dir entries and update the few
references to them with absolute include paths instead.
Finally fixed a few lint errors and invalid header guards.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-18 21:46:20]

Description was changed from

==========
modules/audio_coding: Remove some codec include dirs

Also clean up some include_dir entries and update the few
references to them with absolute include paths instead.
Finally fixed a few lint errors and invalid header guards.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

to

==========
modules/audio_coding: Remove some codec include dirs

Also clean up some include_dir entries and update the few
references to them with absolute include paths instead.
Finally fixed a few lint errors and invalid header guards.

None of these are used downstream.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-18 22:08:52]

Committed patchset #5 (id:80001) manually as
3c652b67468d182bd36aee4c31557621be50cc92 (presubmit successful).

[commit-bot: I haz the power, 2015-11-18 22:08:56]

Patchset 5 (id:??) landed as
https://crrev.com/3c652b67468d182bd36aee4c31557621be50cc92
Cr-Commit-Position: refs/heads/master@{#10700}