Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1438663003: modules/audio_coding: Remove some codec include dirs (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

modules/audio_coding: Remove some codec include dirs Also clean up some include_dir entries and update the few references to them with absolute include paths instead. Finally fixed a few lint errors and invalid header guards. None of these are used downstream. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=kwiberg@webrtc.org Committed: https://crrev.com/3c652b67468d182bd36aee4c31557621be50cc92 Cr-Commit-Position: refs/heads/master@{#10700}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Updated needed after rebase #

Total comments: 2

Patch Set 4 : Rebased #

Patch Set 5 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -2166 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 7 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/cng.gypi View 1 chunk +3 lines, -13 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/cng/include/webrtc_cng.h View 1 chunk +0 lines, -163 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/cng/webrtc_cng.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 chunk +5 lines, -15 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/g711/g711_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g711/include/audio_decoder_pcm.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g711/include/audio_encoder_pcm.h View 1 chunk +0 lines, -117 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g711/include/g711_interface.h View 1 chunk +0 lines, -135 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/test/testG711.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 chunk +4 lines, -14 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/g722/g722_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g722/include/audio_decoder_g722.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g722/include/audio_encoder_g722.h View 1 chunk +0 lines, -73 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g722/include/g722_interface.h View 1 chunk +0 lines, -182 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/test/testG722.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/ilbc.h View 4 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 2 chunks +3 lines, -13 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/include/audio_encoder_ilbc.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/include/ilbc.h View 1 chunk +0 lines, -258 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/test/iLBC_test.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/test/iLBC_testLib.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/test/iLBC_testprogram.c View 1 chunk +7 lines, -7 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/audio_decoder_opus.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_decoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/include/audio_decoder_opus.h View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/include/audio_encoder_opus.h View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/include/opus_interface.h View 1 chunk +0 lines, -349 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus.gypi View 2 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_fec_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/opus_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_speed_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/include/audio_decoder_pcm16b.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/include/audio_encoder_pcm16b.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h View 1 chunk +0 lines, -68 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi View 1 chunk +3 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/target_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/comfort_noise.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_external_decoder_pcm16b.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/normal.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/RTPencode.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_webrtc
kwiberg: main review henrik.lundin: rubberstamp.
5 years, 1 month ago (2015-11-11 20:43:08 UTC) #2
kwiberg-webrtc
On 2015/11/11 20:43:08, kjellander (webrtc) wrote: > kwiberg: main review > henrik.lundin: rubberstamp. Just to ...
5 years, 1 month ago (2015-11-12 09:33:03 UTC) #3
kjellander_webrtc
On 2015/11/12 09:33:03, kwiberg-webrtc wrote: > On 2015/11/11 20:43:08, kjellander (webrtc) wrote: > > kwiberg: ...
5 years, 1 month ago (2015-11-12 10:21:31 UTC) #4
kwiberg-webrtc
lgtm Thanks for doing this. It's good to signal that we don't want random users ...
5 years, 1 month ago (2015-11-12 11:40:45 UTC) #5
kjellander (google.com)
https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_coding/codecs/ilbc/ilbc.h File webrtc/modules/audio_coding/codecs/ilbc/ilbc.h (right): https://codereview.webrtc.org/1438663003/diff/40001/webrtc/modules/audio_coding/codecs/ilbc/ilbc.h#newcode59 webrtc/modules/audio_coding/codecs/ilbc/ilbc.h:59: * - size : The size that this structure ...
5 years, 1 month ago (2015-11-12 11:45:26 UTC) #7
kjellander_webrtc
Committed patchset #5 (id:80001) manually as 3c652b67468d182bd36aee4c31557621be50cc92 (presubmit successful).
5 years, 1 month ago (2015-11-18 22:08:52 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:08:56 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3c652b67468d182bd36aee4c31557621be50cc92
Cr-Commit-Position: refs/heads/master@{#10700}

Powered by Google App Engine
This is Rietveld 408576698