Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1438543002: Revert of Work on flexible mode and screen sharing. (Closed)

Created:
5 years, 1 month ago by terelius
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ ) Reason for revert: Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot. Original issue's description: > Work on flexible mode and screen sharing. > > Implement VP8 style screensharing but with spatial layers. > Implement flexible mode. > > Files from other patches: > generic_encoder.cc > layer_filtering_transport.cc > > BUG=webrtc:4914 > > Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a > Cr-Commit-Position: refs/heads/master@{#10572} TBR=sprang@webrtc.org,stefan@webrtc.org,philipel@google.com,asapersson@webrtc.org,mflodman@webrtc.org,philipel@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4914 Committed: https://crrev.com/0be8f1d347bdb171462df89c2a4c69b3f3eb7519 Cr-Commit-Position: refs/heads/master@{#10578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1121 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/interface/video_codec_interface.h View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp9/screenshare_layers.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp9/screenshare_layers.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp9/screenshare_layers_unittest.cc View 1 chunk +0 lines, -323 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 4 chunks +1 line, -34 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 12 chunks +16 lines, -176 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state.h View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state.cc View 6 chunks +3 lines, -66 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state_unittest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M webrtc/modules/video_coding/main/source/encoded_frame.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/main/source/jitter_buffer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/video/full_stack.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 4 chunks +13 lines, -66 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
terelius
Created Revert of Work on flexible mode and screen sharing.
5 years, 1 month ago (2015-11-10 13:30:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438543002/1
5 years, 1 month ago (2015-11-10 13:31:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 13:31:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0be8f1d347bdb171462df89c2a4c69b3f3eb7519 Cr-Commit-Position: refs/heads/master@{#10578}
5 years, 1 month ago (2015-11-10 13:31:33 UTC) #4
philipel1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1432553008/ by philipel@google.com. ...
5 years, 1 month ago (2015-11-10 14:57:43 UTC) #5
philipel
5 years, 1 month ago (2015-11-10 15:17:07 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1431283002/ by philipel@webrtc.org.

The reason for reverting is: Failed test not related to this CL (test fails on
master at an earlier date), re-landing original CL..

(This time from my @webrtc account.).

Powered by Google App Engine
This is Rietveld 408576698