Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438223003: Android EglBase: Add support for creating EGLSurface from Surface, not SurfaceHolder (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android EglBase: Add support for creating EGLSurface from Surface, not SurfaceHolder Committed: https://crrev.com/3e0f602055f2980d805b0f9b4aa584e675788925 Cr-Commit-Position: refs/heads/master@{#10646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 2 chunks +68 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 1 month ago (2015-11-12 16:23:28 UTC) #2
perkj_webrtc
On 2015/11/12 16:23:28, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 1 month ago (2015-11-16 06:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438223003/1
5 years, 1 month ago (2015-11-16 09:15:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 10:04:54 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 10:05:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e0f602055f2980d805b0f9b4aa584e675788925
Cr-Commit-Position: refs/heads/master@{#10646}

Powered by Google App Engine
This is Rietveld 408576698