Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1437933002: Fix a bug when we can't get default address (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pthatcher, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

When running this code in chromium on a machine with IPv6 disabled, the RTC_DCHECK fails and in release build, it could leak to further crash in chromium's rtc_peer_connection_hanlder.cc. Here is the right fix. BUG=webrtc:5061 R=pthatcher@google.com TBR=pthatcher@webrtc.org Committed: https://crrev.com/e03cab94c1bac43f4d6c4775023a957f98ee8132 Cr-Commit-Position: refs/heads/master@{#10607}

Patch Set 1 : #

Patch Set 2 : fix comments #

Patch Set 3 : minor tweak on the fix. #

Patch Set 4 : #

Patch Set 5 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M webrtc/base/network.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunport.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stunport.cc View 1 2 3 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
pthatcher
lgtm It would be good to have a unit test for this. Can you add ...
5 years, 1 month ago (2015-11-11 19:05:28 UTC) #6
guoweis_webrtc
Committed patchset #5 (id:90001) manually as e03cab94c1bac43f4d6c4775023a957f98ee8132 (presubmit successful).
5 years, 1 month ago (2015-11-11 19:11:32 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 19:11:36 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e03cab94c1bac43f4d6c4775023a957f98ee8132
Cr-Commit-Position: refs/heads/master@{#10607}

Powered by Google App Engine
This is Rietveld 408576698