Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1437823002: Fix potential tearing issue in VideoRendererGui. (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix potential tearing issue in VideoRendererGui. This make sure that the texture copy is syncronized. To reproduce the problem I: Reverted "Revert of "Android MediaCodecVideoDecoder: Manage lifetime of texture frames" https://codereview.webrtc.org/1378033003/" commit 543b6ca30a43eeb069c699291460ce6bacc7959d. Reverted "Enable SurfaceViewRenderer for AppRTCDemo" commit 7076729c57c27aa813760d2038be02c36f4d7649. and ran ApprtDemo in loopback and changed the orientation a couple of times. TBR=glaznev@webrtc.org Committed: https://crrev.com/cbfabbf818717bfaea1740779cf199b740a69e5f Cr-Commit-Position: refs/heads/master@{#10598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
perkj_webrtc
Please
5 years, 1 month ago (2015-11-11 10:01:07 UTC) #2
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-11 10:12:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437823002/1
5 years, 1 month ago (2015-11-11 10:36:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 11:38:42 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 11:38:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbfabbf818717bfaea1740779cf199b740a69e5f
Cr-Commit-Position: refs/heads/master@{#10598}

Powered by Google App Engine
This is Rietveld 408576698