Remove BundleFilter filtering of RTCP.

talk/session/media/bundlefilter.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 10 matching lines @@
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef TALK_SESSION_MEDIA_BUNDLEFILTER_H_
 #define TALK_SESSION_MEDIA_BUNDLEFILTER_H_
 
+#include <stdint.h>
+
 #include <set>
 #include <vector>
 
 #include "talk/media/base/streamparams.h"
 #include "webrtc/base/basictypes.h"
 
 namespace cricket {
 
 // In case of single RTP session and single transport channel, all session
 // ( or media) channels share a common transport channel. Hence they all get
 // SignalReadPacket when packet received on transport channel. This requires
 // cricket::BaseChannel to know all the valid sources, else media channel
 // will decode invalid packets.
 //
 // This class determines whether a packet is destined for cricket::BaseChannel.
 // For rtp packets, this is decided based on the payload type. For rtcp packets,
 // this is decided based on the sender ssrc values.

[hta-webrtc, 2015/11/12 16:47:53]

You need to change this comment too.

[pbos-webrtc, 2015/11/13 11:10:16]

Done.

 class BundleFilter {
  public:
   BundleFilter();
   ~BundleFilter();
 
   // Determines packet belongs to valid cricket::BaseChannel.
-  bool DemuxPacket(const char* data, size_t len, bool rtcp);
+  bool DemuxPacket(const uint8_t* data, size_t len);

[hta-webrtc, 2015/11/12 16:47:53]

Since that's not what it does any more, what about renaming this function to
"CheckIfPayloadTypeIsValid"?

[juberti, 2015/11/13 07:34:23]

This name still seems fine to me. In the future this code may need to demux by
MID extension, so no point in changing the name to something less general.

[pbos-webrtc, 2015/11/13 11:10:16]

Going with not changing it, but I changed the comment to mention RTP packets.

 
   // Adds the supported payload type.
   void AddPayloadType(int payload_type);
 
-  // Adding a valid source to the filter.
-  bool AddStream(const StreamParams& stream);
-
-  // Removes source from the filter.
-  bool RemoveStream(uint32_t ssrc);
-
-  // Utility methods added for unitest.
-  // True if |streams_| is not empty.
-  bool HasStreams() const;
-  bool FindStream(uint32_t ssrc) const;
+  // Public for unittests.
   bool FindPayloadType(int pl_type) const;
   void ClearAllPayloadTypes();
 
-
  private:
   std::set<int> payload_types_;
-  std::vector<StreamParams> streams_;
 };
 
 }  // namespace cricket
 
 #endif  // TALK_SESSION_MEDIA_BUNDLEFILTER_H_