Android SurfaceViewRenderer: Call glClear() for every frame to avoid bad GL state

Android SurfaceViewRenderer: Call glClear() for every frame to avoid bad GL state

BUG=webrtc:5147
Committed: https://crrev.com/fc6affc60d2298600c1c8433fd918226f4f38a5b
Cr-Commit-Position: refs/heads/master@{#10617}

[magjed_webrtc, 2015-11-11 15:29:44]

Description was changed from

==========
Android SurfaceViewRenderer: Call glClear() for every frame to avoid bad GL
state

BUG=webrtc:5147
==========

to

==========
Android SurfaceViewRenderer: Call glClear() for every frame to avoid bad GL
state

BUG=webrtc:5147
==========

[magjed_webrtc, 2015-11-11 15:29:44]

magjed@webrtc.org changed reviewers:
+ hbos@webrtc.org

[magjed_webrtc, 2015-11-11 15:29:57]

hbos - Please take a look.

[hbos, 2015-11-12 08:23:06]

Yeah this makes no sense, lgtm.

https://codereview.webrtc.org/1436883002/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java (right):

https://codereview.webrtc.org/1436883002/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:446:
makeBlack();
Should you not do return here?

[magjed_webrtc, 2015-11-12 08:39:44]

https://codereview.webrtc.org/1436883002/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java (right):

https://codereview.webrtc.org/1436883002/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:446:
makeBlack();
On 2015/11/12 08:23:05, hbos wrote:
> Should you not do return here?

No, because I want to continue and render the real frame asap. The EGLSurface
may have one buffer left with the old size after a resize, so I make it black,
and then the next buffer has correct size so I can continue immediately to
render the real frame.

[magjed_webrtc, 2015-11-12 08:40:24]

Yeah, I agree it makes no sense. I hope I can remove this glClear() in the
future.

[magjed_webrtc, 2015-11-12 08:40:29]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2015-11-12 08:40:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436883002/1

[commit-bot: I haz the power, 2015-11-12 09:08:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-12 09:08:43]

Patchset 1 (id:??) landed as
https://crrev.com/fc6affc60d2298600c1c8433fd918226f4f38a5b
Cr-Commit-Position: refs/heads/master@{#10617}