Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1436753003: Add waiting to SetSendSsrc tests. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add waiting to SetSendSsrc tests. These tests were flaky since a paced packet could arrive between consecutive calls to NumRtpPackets or NumRtpBytes. BUG=webrtc:5193 R=stefan@webrtc.org TBR=pthatcher@webrtc.org Committed: https://crrev.com/718b6c72ae3c8a88ff4bbe672874e122a7c15bff Cr-Commit-Position: refs/heads/master@{#10603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M talk/media/base/videoengine_unittest.h View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
stefan-webrtc
lgtm
5 years, 1 month ago (2015-11-11 16:17:17 UTC) #1
pbos-webrtc
Committed patchset #1 (id:1) manually as 718b6c72ae3c8a88ff4bbe672874e122a7c15bff (presubmit successful).
5 years, 1 month ago (2015-11-11 16:19:46 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 16:19:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/718b6c72ae3c8a88ff4bbe672874e122a7c15bff
Cr-Commit-Position: refs/heads/master@{#10603}

Powered by Google App Engine
This is Rietveld 408576698