Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435873003: Use webrtc/base/logging.h for video coding/processing. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use webrtc/base/logging.h for video coding/processing. Replaces system_wrappers' logging.h in video_coding and video_processing. BUG=webrtc:5118 R=stefan@webrtc.org Committed: https://crrev.com/854e84c7fb61972bd8e39c1482e5f3e31f796b5f Cr-Commit-Position: refs/heads/master@{#10664}

Patch Set 1 #

Patch Set 2 : move stdint/stdio headers to proper location #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/frame_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/generic_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/jitter_buffer.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/session_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_receiver.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/include/vp8_header_parser.h View 1 1 chunk +3 lines, -0 lines 2 comments Download
M webrtc/modules/video_coding/utility/vp8_header_parser.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/video_processing/main/source/deflickering.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/main/source/video_processing_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
pbos-webrtc
PTAL
5 years, 1 month ago (2015-11-11 14:59:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435873003/1
5 years, 1 month ago (2015-11-11 15:00:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/1090)
5 years, 1 month ago (2015-11-11 15:02:28 UTC) #5
pbos-webrtc
move stdint/stdio headers to proper location
5 years, 1 month ago (2015-11-11 15:08:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435873003/20001
5 years, 1 month ago (2015-11-11 15:16:23 UTC) #8
stefan-webrtc
https://codereview.webrtc.org/1435873003/diff/20001/webrtc/modules/video_coding/utility/include/vp8_header_parser.h File webrtc/modules/video_coding/utility/include/vp8_header_parser.h (right): https://codereview.webrtc.org/1435873003/diff/20001/webrtc/modules/video_coding/utility/include/vp8_header_parser.h#newcode15 webrtc/modules/video_coding/utility/include/vp8_header_parser.h:15: #include <stdio.h> Why was this moved?
5 years, 1 month ago (2015-11-11 16:12:39 UTC) #9
pbos-webrtc
https://codereview.webrtc.org/1435873003/diff/20001/webrtc/modules/video_coding/utility/include/vp8_header_parser.h File webrtc/modules/video_coding/utility/include/vp8_header_parser.h (right): https://codereview.webrtc.org/1435873003/diff/20001/webrtc/modules/video_coding/utility/include/vp8_header_parser.h#newcode15 webrtc/modules/video_coding/utility/include/vp8_header_parser.h:15: #include <stdio.h> On 2015/11/11 16:12:38, stefan-webrtc (holmer) wrote: > ...
5 years, 1 month ago (2015-11-11 16:16:21 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 16:44:21 UTC) #12
stefan-webrtc
lgtm
5 years, 1 month ago (2015-11-16 19:26:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435873003/20001
5 years, 1 month ago (2015-11-16 23:45:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 00:39:10 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 00:39:16 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/854e84c7fb61972bd8e39c1482e5f3e31f796b5f
Cr-Commit-Position: refs/heads/master@{#10664}

Powered by Google App Engine
This is Rietveld 408576698