Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 1435413006: Android SurfaceViewRenderer: Never hold a pending frame indefinitely (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android SurfaceViewRenderer: Never hold a pending frame indefinitely The original purpose with keeping one pending frame in SurfaceViewRenderer was to reduce latency for the first rendered frame when we are waiting for the Surface to be created. However, it is very dangerous to hold a pending frame indefinitely when used with a SurfaceTexture, because the SurfaceTexture only has one frame and thus holding a frame in the renderer will freeze everything and typically cause timeout crashes. Committed: https://crrev.com/4a41361f9819b995946a87e32abe008734528cee Cr-Commit-Position: refs/heads/master@{#10638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 1 month ago (2015-11-13 15:25:09 UTC) #3
perkj_webrtc
lgtm thanks
5 years, 1 month ago (2015-11-13 15:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435413006/1
5 years, 1 month ago (2015-11-13 16:20:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 16:48:07 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 16:48:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a41361f9819b995946a87e32abe008734528cee
Cr-Commit-Position: refs/heads/master@{#10638}

Powered by Google App Engine
This is Rietveld 408576698