Remove include dirs from modules/{media_file,pacing}

Remove include dirs from modules/{media_file,pacing}

Also move files out of media_file/source.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=asapersson@webrtc.org, perkj@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/0b9e29c87da2d9c1a3792d2c87197b0688b68e4e
Cr-Commit-Position: refs/heads/master@{#10647}

[kjellander_webrtc, 2015-11-11 21:27:12]

Description was changed from

==========
Remove include dirs from modules/{media_file,pacing}

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

to

==========
Remove include dirs from modules/{media_file,pacing}

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-11 21:27:12]

kjellander@webrtc.org changed reviewers:
+ asapersson@webrtc.org, perkj@webrtc.org

[kjellander_webrtc, 2015-11-11 21:41:56]

asapersson: pacer
perkj: media_file

[kjellander_webrtc, 2015-11-11 21:42:22]

Description was changed from

==========
Remove include dirs from modules/{media_file,pacing}

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

to

==========
Remove include dirs from modules/{media_file,pacing}

Also move files out of media_file/source.

BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[perkj_webrtc, 2015-11-12 09:49:44]

On 2015/11/11 21:41:56, kjellander (webrtc) wrote:
> asapersson: pacer
> perkj: media_file

please ask the solenberg and mflodman if you can just delete modules/media_file.
I guess its an old way of recording stuff but I don't think it is used or maybe
even does not work any longer.

[kjellander_webrtc, 2015-11-12 10:18:52]

On 2015/11/12 09:49:44, perkj1 wrote:
> On 2015/11/11 21:41:56, kjellander (webrtc) wrote:
> > asapersson: pacer
> > perkj: media_file
> 
> please ask the solenberg and mflodman if you can just delete
modules/media_file.
> I guess its an old way of recording stuff but I don't think it is used or
maybe
> even does not work any longer.

+mflodman@webrtc.org, solenberg@webrtc.org:

Can we just delete modules/media_file?

perkj: I'd prefer to do that in a follow up CL either way, since I'd like to get
this in (since rebasing may be a pain and risky if other CLs are committed
during this review period).

[The Sun (google.com), 2015-11-12 10:45:27]

On 2015/11/12 10:18:52, kjellander (webrtc) wrote:
> On 2015/11/12 09:49:44, perkj1 wrote:
> > On 2015/11/11 21:41:56, kjellander (webrtc) wrote:
> > > asapersson: pacer
> > > perkj: media_file
> > 
> > please ask the solenberg and mflodman if you can just delete
> modules/media_file.
> > I guess its an old way of recording stuff but I don't think it is used or
> maybe
> > even does not work any longer.
> 
> mailto:+mflodman@webrtc.org, mailto:solenberg@webrtc.org:
> 
> Can we just delete modules/media_file?
> 
> perkj: I'd prefer to do that in a follow up CL either way, since I'd like to
get
> this in (since rebasing may be a pain and risky if other CLs are committed
> during this review period).

Nope, media_file needs to stay for some time - it is being used to implement the
VoEFile API, which in turn is used by 3rd parties and a few of our tests.
"Soon..."

[perkj_webrtc, 2015-11-16 06:32:02]

On 2015/11/12 10:45:27, solenberg wrote:
> On 2015/11/12 10:18:52, kjellander (webrtc) wrote:
> > On 2015/11/12 09:49:44, perkj1 wrote:
> > > On 2015/11/11 21:41:56, kjellander (webrtc) wrote:
> > > > asapersson: pacer
> > > > perkj: media_file
> > > 
> > > please ask the solenberg and mflodman if you can just delete
> > modules/media_file.
> > > I guess its an old way of recording stuff but I don't think it is used or
> > maybe
> > > even does not work any longer.
> > 
> > mailto:+mflodman@webrtc.org, mailto:solenberg@webrtc.org:
> > 
> > Can we just delete modules/media_file?
> > 
> > perkj: I'd prefer to do that in a follow up CL either way, since I'd like to
> get
> > this in (since rebasing may be a pain and risky if other CLs are committed
> > during this review period).
> 
> Nope, media_file needs to stay for some time - it is being used to implement
the
> VoEFile API, which in turn is used by 3rd parties and a few of our tests.
> "Soon..."

ok
lgtm

[kjellander_webrtc, 2015-11-16 07:06:45]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2015-11-16 07:06:45]

asapersson: can you take a look?

+tommi: for root OWNER rubberstamp.

[åsapersson, 2015-11-16 07:44:40]

lgtm

[tommi, 2015-11-16 09:09:55]

rs lgtm

[kjellander_webrtc, 2015-11-16 10:12:38]

Committed patchset #3 (id:40001) manually as
0b9e29c87da2d9c1a3792d2c87197b0688b68e4e (presubmit successful).

[commit-bot: I haz the power, 2015-11-16 10:12:42]

Patchset 3 (id:??) landed as
https://crrev.com/0b9e29c87da2d9c1a3792d2c87197b0688b68e4e
Cr-Commit-Position: refs/heads/master@{#10647}