rtcp::Ij renamed to rtcp::ExtendedJitterReport and moved into own file

rtcp::Ij renamed to rtcp::ExtendedJitterReport
  to match name given in the RFC5450
  private member renamed to inter_arrival_jitters_ for the same reason.
rtcp::ExtendedJitterReport moved into own file
accessors and Parse function added
  to make class usable for parsing packet

Committed: https://crrev.com/f8506cbdd88ce538d9e6c28ee39111345189778f
Cr-Commit-Position: refs/heads/master@{#10636}

[danilchap, 2015-11-12 12:36:16]

Description was changed from

==========
rtcp::Ij renamed to rtcp::ExtendedJitterReport and moved into own file

BUG=
==========

to

==========
rtcp::Ij renamed to rtcp::ExtendedJitterReport
  to match name given in the RFC5450
  private member renamed to inter_arrival_jitters_ for the same reason.
rtcp::ExtendedJitterReport moved into own file
accessors and Parse function added
  to make class usable for parsing packet
==========

[danilchap, 2015-11-12 12:36:16]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[åsapersson, 2015-11-12 15:44:31]

LG, a few minor comments.

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:43:
RTC_DCHECK(header.packet_type == kPacketType);
RTC_DCHECK_EQ(kPacketType, ...

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:46: const
size_t kJitterSize = 4u;
maybe kJitterSizeBytes

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:49:
LOG(LS_WARNING) << "Packet is too small to contain all the jitter";
nit: period

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h:37: uint32_t
jitter(size_t index) const { return inter_arrival_jitters_[index]; }
add validation/check of index

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc:33:
EXPECT_TRUE(header.packet_type == ExtendedJitterReport::kPacketType);
Checked within Parse?

[danilchap, 2015-11-13 09:52:48]

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:43:
RTC_DCHECK(header.packet_type == kPacketType);
On 2015/11/12 15:44:31, åsapersson wrote:
> RTC_DCHECK_EQ(kPacketType, ...

Unfortunetly this syntax creates additional complications:
RTC_DCHECK_EQ take parameters as const references. Because of that compiler
tries to take address of kPacketType which fails at linking time. 
There are several ways to resolve it:
 * move initialization of kPacketType to .cc limit. 
   This way it would not be possible to use ExternalJitterReport::kPacketType as
a switch branch, something I plan to do.
 * replace static const uint8_t with anonymous enum
   enum : uint8_t { kPacketType = 195 };
   would work, but looks ugly
 * have a temporary constant variable:
   const uint8_t tmp = kPacketType;
   RTC_DCHECK_EQ(tmp, header.packet_type);
   would work, but looks worse than enum
 * use general RTC_DCHECK instead of RTC_DCHECK_EQ
   This seems to me less ugly than other options

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:46: const
size_t kJitterSize = 4u;
On 2015/11/12 15:44:31, åsapersson wrote:
> maybe kJitterSizeBytes

Done.

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc:49:
LOG(LS_WARNING) << "Packet is too small to contain all the jitter";
On 2015/11/12 15:44:31, åsapersson wrote:
> nit: period

Done.

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h:37: uint32_t
jitter(size_t index) const { return inter_arrival_jitters_[index]; }
On 2015/11/12 15:44:31, åsapersson wrote:
> add validation/check of index

Done.

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
(right):

https://codereview.webrtc.org/1434213004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc:33:
EXPECT_TRUE(header.packet_type == ExtendedJitterReport::kPacketType);
On 2015/11/12 15:44:31, åsapersson wrote:
> Checked within Parse?

Done.

[åsapersson, 2015-11-13 13:30:39]

lgtm

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc (right):

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:17: #include
"webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h"
needed?

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:27: using
webrtc::rtcp::ExtendedJitterReport;
needed?

[danilchap, 2015-11-13 13:52:19]

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc (right):

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:17: #include
"webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h"
On 2015/11/13 13:30:39, åsapersson wrote:
> needed?

Done.

https://codereview.webrtc.org/1434213004/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:27: using
webrtc::rtcp::ExtendedJitterReport;
On 2015/11/13 13:30:39, åsapersson wrote:
> needed?

Done.

[danilchap, 2015-11-13 13:52:24]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-11-13 13:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1434213004/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-11-13 13:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434213004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434213004/60001

[commit-bot: I haz the power, 2015-11-13 13:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 13:53:10]

Try jobs failed on following builders:
  android_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/6954)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/5586)
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/10735)
  linux_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/6741)
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/10763)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_x64_dbg/bui...)

[danilchap, 2015-11-13 14:21:18]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-11-13 14:21:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1434213004/#ps80001 (title:
"Resolved merge conflict")

[commit-bot: I haz the power, 2015-11-13 14:21:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434213004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434213004/80001

[commit-bot: I haz the power, 2015-11-13 15:33:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-13 15:33:36]

Patchset 5 (id:??) landed as
https://crrev.com/f8506cbdd88ce538d9e6c28ee39111345189778f
Cr-Commit-Position: refs/heads/master@{#10636}