Add separate send-side UMA stats for screenshare and video.

webrtc/video/send_statistics_proxy.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 40 matching lines @@
   // Used to update encode time of frames.
   void OnEncodedFrame(int encode_time_ms);
 
   // From VideoEncoderRateObserver.
   void OnSetRates(uint32_t bitrate_bps, int framerate) override;
 
   void OnOutgoingRate(uint32_t framerate, uint32_t bitrate);
   void OnSuspendChange(bool is_suspended);
   void OnInactiveSsrc(uint32_t ssrc);
 
+  void SetCodecMode(VideoCodecMode mode);
+
  protected:
   // From CpuOveruseMetricsObserver.
   void CpuOveruseMetricsUpdated(const CpuOveruseMetrics& metrics) override;
   // From RtcpStatisticsCallback.
   void StatisticsUpdated(const RtcpStatistics& statistics,
                          uint32_t ssrc) override;
   void CNameChanged(const char* cname, uint32_t ssrc) override;
   // From RtcpPacketTypeCounterObserver.
   void RtcpPacketTypesCounterUpdated(
       uint32_t ssrc,
@@ skipping 34 matching lines @@
     void Add(bool sample);
     int Percent(int min_required_samples) const;
     int Permille(int min_required_samples) const;
 
    private:
     int Fraction(int min_required_samples, float multiplier) const;
     int sum;
     int num_samples;
   };
   struct StatsUpdateTimes {
-    StatsUpdateTimes() : resolution_update_ms(0) {}
+    StatsUpdateTimes() : resolution_update_ms(0), bitrate_update_ms(0) {}
     int64_t resolution_update_ms;
     int64_t bitrate_update_ms;
   };
   void PurgeOldStats() EXCLUSIVE_LOCKS_REQUIRED(crit_);
   VideoSendStream::StreamStats* GetStatsEntry(uint32_t ssrc)
       EXCLUSIVE_LOCKS_REQUIRED(crit_);
-  void UpdateHistograms() EXCLUSIVE_LOCKS_REQUIRED(crit_);
 
   Clock* const clock_;
   const VideoSendStream::Config config_;
+  VideoCodecMode codec_mode_ GUARDED_BY(crit_);
   mutable rtc::CriticalSection crit_;
   VideoSendStream::Stats stats_ GUARDED_BY(crit_);
-  rtc::RateTracker input_frame_rate_tracker_ GUARDED_BY(crit_);
-  rtc::RateTracker sent_frame_rate_tracker_ GUARDED_BY(crit_);
-  uint32_t last_sent_frame_timestamp_ GUARDED_BY(crit_);
-  std::map<uint32_t, StatsUpdateTimes> update_times_ GUARDED_BY(crit_);
 
-  int max_sent_width_per_timestamp_ GUARDED_BY(crit_);
-  int max_sent_height_per_timestamp_ GUARDED_BY(crit_);
-  SampleCounter input_width_counter_ GUARDED_BY(crit_);
-  SampleCounter input_height_counter_ GUARDED_BY(crit_);
-  SampleCounter sent_width_counter_ GUARDED_BY(crit_);
-  SampleCounter sent_height_counter_ GUARDED_BY(crit_);
-  SampleCounter encode_time_counter_ GUARDED_BY(crit_);
-  BoolSampleCounter key_frame_counter_ GUARDED_BY(crit_);
-  BoolSampleCounter quality_limited_frame_counter_ GUARDED_BY(crit_);
-  SampleCounter quality_downscales_counter_ GUARDED_BY(crit_);
-  BoolSampleCounter bw_limited_frame_counter_ GUARDED_BY(crit_);
-  SampleCounter bw_resolutions_disabled_counter_ GUARDED_BY(crit_);
-  SampleCounter delay_counter_ GUARDED_BY(crit_);
-  SampleCounter max_delay_counter_ GUARDED_BY(crit_);
+  struct StatsSet {

[pbos-webrtc, 2015/11/12 10:38:19]

StatsSet sounds too generic, can you think of a name that also says what it
contains, or put a comment above with why we need it separate (that it resets
between screenshare/realtime)?

[sprang_webrtc, 2015/11/12 11:01:25]

Done.

+    explicit StatsSet(const char* prefix)

[pbos-webrtc, 2015/11/12 10:38:19]

Put constructor in .cc file.

[sprang_webrtc, 2015/11/12 11:01:25]

Done.

+        : kPrefix(prefix),
+          input_frame_rate_tracker_(100u, 10u),
+          sent_frame_rate_tracker_(100u, 10u),
+          last_sent_frame_timestamp_(0),
+          max_sent_width_per_timestamp_(0),
+          max_sent_height_per_timestamp_(0) {}
+    const std::string kPrefix;

[pbos-webrtc, 2015/11/12 10:38:19]

stats_prefix_, "const" doesn't make it a "kConstant".

[sprang_webrtc, 2015/11/12 11:01:25]

Done.

+    rtc::RateTracker input_frame_rate_tracker_;
+    rtc::RateTracker sent_frame_rate_tracker_;
+    uint32_t last_sent_frame_timestamp_;
+    std::map<uint32_t, StatsUpdateTimes> update_times_;
+
+    int max_sent_width_per_timestamp_;
+    int max_sent_height_per_timestamp_;
+    SampleCounter input_width_counter_;
+    SampleCounter input_height_counter_;
+    SampleCounter sent_width_counter_;
+    SampleCounter sent_height_counter_;
+    SampleCounter encode_time_counter_;
+    BoolSampleCounter key_frame_counter_;
+    BoolSampleCounter quality_limited_frame_counter_;
+    SampleCounter quality_downscales_counter_;
+    BoolSampleCounter bw_limited_frame_counter_;
+    SampleCounter bw_resolutions_disabled_counter_;
+    SampleCounter delay_counter_;
+    SampleCounter max_delay_counter_;
+
+    void UpdateHistograms();
+  };
+
+  rtc::scoped_ptr<StatsSet> stats_set_ GUARDED_BY(crit_);

[pbos-webrtc, 2015/11/12 10:38:19]

Since this doesn't rely on a destructor being called, skip the scoped_ptr and
just copy-replace it.

[sprang_webrtc, 2015/11/12 11:01:25]

Ugh, that would mean I have to add copy assignment operators to most of the
classes it contains. Do I have to? :)

[pbos-webrtc, 2015/11/12 11:09:40]

They're not copy-constructible by default?

[sprang_webrtc, 2015/11/12 13:32:06]

Nope. :(

 };
 
 }  // namespace webrtc
 #endif  // WEBRTC_VIDEO_SEND_STATISTICS_PROXY_H_