Add aecdump support to audioproc_f

Add aecdump support to audioproc_f

Originally landed here: https://codereview.webrtc.org/1409943002/
The transient suppression fix landed here: https://codereview.webrtc.org/1411423010/

TBR=mflodman

Committed: https://crrev.com/b0ad43baa02f41dba01be4df9606dc65f24c0ec8
Cr-Commit-Position: refs/heads/master@{#10722}

[aluebs-webrtc, 2015-11-17 03:10:15]

Patchset #3 (id:40001) has been deleted

[aluebs-webrtc, 2015-11-17 03:15:28]

Description was changed from

==========
Add aecdump support to audioproc_f

Originally landed here: https://codereview.webrtc.org/1409943002/
==========

to

==========
Add aecdump support to audioproc_f

Originally landed here: https://codereview.webrtc.org/1409943002/
The transient suppression fix landed here:
https://codereview.webrtc.org/1411423010/
==========

[aluebs-webrtc, 2015-11-17 03:25:55]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, kjellander@webrtc.org, mflodman@webrtc.org

[aluebs-webrtc, 2015-11-17 03:25:55]

I want to re-land this. The only changes that haven't been reviewed is the patch
4, "Fix gyp dependency issue in iOS".

kjellander, PTAL at patch 4.
mflodman, PTAL at tick_util.h, but it has been reviewed in the original CL
already.
henrik.lundin, PTAL at common_audio and audio_processing, but it has been
reviewed in the original CL already.

[kjellander_webrtc, 2015-11-18 07:11:18]

webrtc/modules/audio_processing/audio_processing_tests.gypi: lgtm

thanks for not adding the dependency on 'audioproc_debug_proto' to the
'audioproc_test_utils' target, since that's what was causing trouble last time
for iOS.
I have yet to remove the build_with_libjingle=1 setting our iOS bots builds
with, but I'm working on that.

[hlundin-webrtc, 2015-11-18 09:19:13]

common_audio and audio_processing: (mostly rubberstamp) LGTM, but with one nit.

https://codereview.webrtc.org/1432843002/diff/20001/webrtc/common_audio/wav_f...
File webrtc/common_audio/wav_file.cc (right):

https://codereview.webrtc.org/1432843002/diff/20001/webrtc/common_audio/wav_f...
webrtc/common_audio/wav_file.cc:41: std::ostringstream s;
Include what you use. std::ostringstream is defined in <sstream>.

[aluebs-webrtc, 2015-11-18 18:35:36]

mflodman, when you have some time, could you please take a look?

https://codereview.webrtc.org/1432843002/diff/20001/webrtc/common_audio/wav_f...
File webrtc/common_audio/wav_file.cc (right):

https://codereview.webrtc.org/1432843002/diff/20001/webrtc/common_audio/wav_f...
webrtc/common_audio/wav_file.cc:41: std::ostringstream s;
On 2015/11/18 09:19:13, hlundin-webrtc wrote:
> Include what you use. std::ostringstream is defined in <sstream>.

Done.

[aluebs-webrtc, 2015-11-19 23:08:47]

Description was changed from

==========
Add aecdump support to audioproc_f

Originally landed here: https://codereview.webrtc.org/1409943002/
The transient suppression fix landed here:
https://codereview.webrtc.org/1411423010/
==========

to

==========
Add aecdump support to audioproc_f

Originally landed here: https://codereview.webrtc.org/1409943002/
The transient suppression fix landed here:
https://codereview.webrtc.org/1411423010/

TBR=mflodman
==========

[aluebs-webrtc, 2015-11-19 23:08:55]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2015-11-19 23:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1432843002/#ps100001 (title:
"Add used includes")

[commit-bot: I haz the power, 2015-11-19 23:09:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432843002/100001

[commit-bot: I haz the power, 2015-11-20 01:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 01:09:27]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[aluebs-webrtc, 2015-11-20 02:26:12]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2015-11-20 02:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432843002/100001

[commit-bot: I haz the power, 2015-11-20 04:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 04:26:30]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2015-11-20 08:08:13]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-11-20 08:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432843002/100001

[kjellander_webrtc, 2015-11-20 08:08:45]

On 2015/11/20 04:26:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

Checking CQ checkbox again as all bots are now green (but didn't make it within
the timeout).

[commit-bot: I haz the power, 2015-11-20 08:11:56]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-11-20 08:12:07]

Patchset 5 (id:??) landed as
https://crrev.com/b0ad43baa02f41dba01be4df9606dc65f24c0ec8
Cr-Commit-Position: refs/heads/master@{#10722}

[Andrew MacDonald, 2015-11-20 18:14:22]

Hooray! Thanks for dealing with the mess I left Mr. Luebs ;-)

[aluebs-webrtc, 2015-11-20 18:50:24]

On 2015/11/20 18:14:22, Andrew MacDonald wrote:
> Hooray! Thanks for dealing with the mess I left Mr. Luebs ;-)

It was my pleasure :)
Except that I had to get a Macbook to build iOS :P

[mflodman, 2015-11-20 20:47:19]

tick_util LGTM