Add oldest rotation type option to RTCFileLogger

webrtc/base/filerotatingstream.cc

Index: webrtc/base/filerotatingstream.cc
diff --git a/webrtc/base/filerotatingstream.cc b/webrtc/base/filerotatingstream.cc
index 65dfd6397f2daf0ab246fbe7b4be815ce06b9e54..080999476b0a0ac1c8f1aa6b765f21c5160ddde5 100644
--- a/webrtc/base/filerotatingstream.cc
+++ b/webrtc/base/filerotatingstream.cc
@@ -281,7 +281,7 @@ void FileRotatingStream::RotateFiles() {
   // Rotates the files by deleting the file at |rotation_index_|, which is the
   // oldest file and then renaming the newer files to have an incremented index.
   // See header file comments for example.
-  RTC_DCHECK_LE(rotation_index_, file_names_.size());

[tkchin_webrtc, 2015/11/16 21:37:25]

did you hit this somehow?

[Chuck, 2015/12/04 22:42:57]

No, was just reading the code to understand how the call log rotation worked.
The next line does files_names_[rotation_index_] so rotation_index_ has to be
less than size() or we crash, right?

+  RTC_DCHECK_LT(rotation_index_, file_names_.size());
   std::string file_to_delete = file_names_[rotation_index_];
   if (Filesystem::IsFile(file_to_delete)) {
     if (!Filesystem::DeleteFile(file_to_delete)) {