Add oldest rotation type option to RTCFileLogger

webrtc/base/filerotatingstream.cc

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 263 matching lines @@
   current_bytes_written_ = 0;
   file_stream_.reset();
 }
 
 void FileRotatingStream::RotateFiles() {
   RTC_DCHECK_EQ(mode_, kWrite);
   CloseCurrentFile();
   // Rotates the files by deleting the file at |rotation_index_|, which is the
   // oldest file and then renaming the newer files to have an incremented index.
   // See header file comments for example.
-  RTC_DCHECK_LE(rotation_index_, file_names_.size());

[tkchin_webrtc, 2015/11/16 21:37:25]

did you hit this somehow?

[Chuck, 2015/12/04 22:42:57]

No, was just reading the code to understand how the call log rotation worked.
The next line does files_names_[rotation_index_] so rotation_index_ has to be
less than size() or we crash, right?

+  RTC_DCHECK_LT(rotation_index_, file_names_.size());
   std::string file_to_delete = file_names_[rotation_index_];
   if (Filesystem::IsFile(file_to_delete)) {
     if (!Filesystem::DeleteFile(file_to_delete)) {
       std::cerr << "Failed to delete: " << file_to_delete << std::endl;
     }
   }
   for (auto i = rotation_index_; i > 0; --i) {
     std::string rotated_name = file_names_[i];
     std::string unrotated_name = file_names_[i - 1];
     if (Filesystem::IsFile(unrotated_name)) {
@@ skipping 96 matching lines @@
 
 size_t CallSessionFileRotatingStream::GetNumRotatingLogFiles(
     size_t max_total_log_size) {
   // At minimum have two rotating files. Otherwise split the available log size
   // evenly across 1MB files.
   return std::max((size_t)2,
                   (max_total_log_size / 2) / kRotatingLogFileDefaultSize);
 }
 
 }  // namespace rtc