Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1432753003: Add oldest rotation type option to RTCFileLogger (Closed)

Created:
5 years, 1 month ago by Chuck
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add oldest rotation type option to RTCFileLogger BUG= Committed: https://crrev.com/d02b0fab76847c72bd45e5a40763255283abe212 Cr-Commit-Position: refs/heads/master@{#10945}

Patch Set 1 #

Patch Set 2 : Add whitespace #

Total comments: 10

Patch Set 3 : Updated per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M talk/app/webrtc/objc/RTCFileLogger.mm View 1 2 4 chunks +36 lines, -5 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCFileLogger.h View 1 2 1 chunk +20 lines, -3 lines 0 comments Download
M webrtc/base/filerotatingstream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
Chuck
5 years, 1 month ago (2015-11-05 23:53:21 UTC) #2
tkchin_webrtc
https://codereview.webrtc.org/1432753003/diff/20001/talk/app/webrtc/objc/RTCFileLogger.mm File talk/app/webrtc/objc/RTCFileLogger.mm (right): https://codereview.webrtc.org/1432753003/diff/20001/talk/app/webrtc/objc/RTCFileLogger.mm#newcode104 talk/app/webrtc/objc/RTCFileLogger.mm:104: if (_rotationType == kRTCFileLoggerRotationTypeOldest) { use a switch here ...
5 years, 1 month ago (2015-11-16 21:37:25 UTC) #3
Chuck
https://codereview.webrtc.org/1432753003/diff/20001/talk/app/webrtc/objc/RTCFileLogger.mm File talk/app/webrtc/objc/RTCFileLogger.mm (right): https://codereview.webrtc.org/1432753003/diff/20001/talk/app/webrtc/objc/RTCFileLogger.mm#newcode104 talk/app/webrtc/objc/RTCFileLogger.mm:104: if (_rotationType == kRTCFileLoggerRotationTypeOldest) { On 2015/11/16 21:37:25, tkchin_webrtc ...
5 years ago (2015-12-04 22:42:57 UTC) #4
tkchin_webrtc
lgtm
5 years ago (2015-12-08 18:50:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432753003/40001
5 years ago (2015-12-08 19:19:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2283)
5 years ago (2015-12-08 19:55:57 UTC) #9
Chuck
@jiayl Need LGTM for filerotatingstream.cc change (changes LE to LT)
5 years ago (2015-12-08 20:12:10 UTC) #11
jiayl2
lgtm
5 years ago (2015-12-08 20:36:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432753003/40001
5 years ago (2015-12-08 20:37:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-08 21:19:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432753003/40001
5 years ago (2015-12-08 21:24:00 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-08 21:59:08 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-08 21:59:20 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d02b0fab76847c72bd45e5a40763255283abe212
Cr-Commit-Position: refs/heads/master@{#10945}

Powered by Google App Engine
This is Rietveld 408576698