Flesh out webrtc/.gitignore

Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.

NOTRY=True
TBR=henrika@webrtc.org

Committed: https://crrev.com/3528a27b1b0beeeb4e929bd33024cf8c2996bead
Cr-Commit-Position: refs/heads/master@{#10656}

[brucedawson, 2015-11-11 21:25:41]

brucedawson@chromium.org changed reviewers:
+ henrika@chromium.org

[brucedawson, 2015-11-11 21:25:41]

Circling back to .gitignore - this would make "git status" work much better for
me and others in the Chromium context. I think that this is the correct way to
deal with this file.

[henrika_webrtc, 2015-11-12 09:01:18]

Description was changed from

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.
==========

to

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.
==========

[henrika_webrtc, 2015-11-12 09:01:18]

henrika@webrtc.org changed reviewers:
+ kjellander@webrtc.org
- henrika@chromium.org

[henrika_webrtc, 2015-11-12 09:01:46]

henrika@webrtc.org changed reviewers:
+ henrika@webrtc.org

[henrika_webrtc, 2015-11-12 09:01:47]

henrika->kjellander as reviewer

[kjellander_webrtc, 2015-11-12 10:25:33]

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore
File webrtc/.gitignore (right):

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore#newcode2
webrtc/.gitignore:2: # is a copy of the .gitignore file in the parent directory.
Let's not make it a copy. Having some wildcard patterns that matches files that
isn't really needed is fine, but not all the entries that obviously never will
exist.

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore#newcode29
webrtc/.gitignore:29: .*.sw?
Please remove everything below this comment. I don't any of them will ever exist
in a Chromium checkout.

[brucedawson, 2015-11-12 18:29:51]

PTAL

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore
File webrtc/.gitignore (right):

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore#newcode2
webrtc/.gitignore:2: # is a copy of the .gitignore file in the parent directory.
On 2015/11/12 10:25:33, kjellander (webrtc) wrote:
> Let's not make it a copy. Having some wildcard patterns that matches files
that
> isn't really needed is fine, but not all the entries that obviously never will
> exist.

Done.

https://codereview.webrtc.org/1432413002/diff/1/webrtc/.gitignore#newcode29
webrtc/.gitignore:29: .*.sw?
On 2015/11/12 10:25:33, kjellander (webrtc) wrote:
> Please remove everything below this comment. I don't any of them will ever
exist
> in a Chromium checkout.

Done.

[kjellander_webrtc, 2015-11-16 04:43:57]

https://codereview.webrtc.org/1432413002/diff/20001/webrtc/.gitignore
File webrtc/.gitignore (right):

https://codereview.webrtc.org/1432413002/diff/20001/webrtc/.gitignore#newcode2
webrtc/.gitignore:2: # is a copy of the head of the .gitignore file in the
parent directory.
Please update the comment as it's no longer true.

[brucedawson, 2015-11-16 18:06:47]

https://codereview.webrtc.org/1432413002/diff/20001/webrtc/.gitignore
File webrtc/.gitignore (right):

https://codereview.webrtc.org/1432413002/diff/20001/webrtc/.gitignore#newcode2
webrtc/.gitignore:2: # is a copy of the head of the .gitignore file in the
parent directory.
On 2015/11/16 04:43:57, kjellander (webrtc) wrote:
> Please update the comment as it's no longer true.

Done.

Technically I had already updated the comment to make it accurate by
saying that it was a copy "of the head" of the .gitignore file. But
that was clearly too subtle since I didn't see it for a while when
responding to this comment. I rewrote it to be more obvious
("truncated copy" instead of "copy of the head").

[kjellander_webrtc, 2015-11-16 18:49:21]

lgtm

[kjellander_webrtc, 2015-11-16 18:49:34]

Description was changed from

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.
==========

to

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.

NOTRY=True
==========

[kjellander_webrtc, 2015-11-16 18:49:56]

On 2015/11/16 18:49:21, kjellander (webrtc) wrote:
> lgtm

Setting NOTRY=True since running trybots doesn't make sense for this change.

[brucedawson, 2015-11-16 18:50:49]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-11-16 18:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432413002/40001

[commit-bot: I haz the power, 2015-11-16 18:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 18:54:29]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1762)

[kjellander (google.com), 2015-11-16 19:00:36]

Description was changed from

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.

NOTRY=True
==========

to

==========
Flesh out webrtc/.gitignore

Chromium only checks out the webrtc directory so it misses the root
level .gitignore file which leads to messy "git status" reports inside
third_party/webrtc. This copies the root level .gitignore so that
.vcxproj files, the OSX equivalent, and other files will be ignored.

Some of the entries are irrelevant, but it is better too have a few
irrelevant entries than to be missing some, and the simplicity of
copying is valuable.

NOTRY=True
TBR=henrika@webrtc.org
==========

[kjellander (google.com), 2015-11-16 19:00:46]

The CQ bit was checked by kjellander@google.com

[kjellander (google.com), 2015-11-16 19:00:54]

On 2015/11/16 18:54:29, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1762)

TBRing henrika

[commit-bot: I haz the power, 2015-11-16 19:00:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432413002/40001

[commit-bot: I haz the power, 2015-11-16 19:01:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-16 19:02:15]

Patchset 3 (id:??) landed as
https://crrev.com/3528a27b1b0beeeb4e929bd33024cf8c2996bead
Cr-Commit-Position: refs/heads/master@{#10656}