Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1431983006: Remove webrtc/test/channel_transport/include (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/test/channel_transport/include Move the header file into webrtc/test/channel_transport instead. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel -m tryserver.webrtc --bot=ios_rel R=henrika@webrtc.org, henrikg@webrtc.org Committed: https://crrev.com/1323fc39babb2638c5795c1e23e97c977c5c29f3 Cr-Commit-Position: refs/heads/master@{#10595}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -69 lines) Patch
M webrtc/examples/android/media_demo/jni/voice_engine_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/test/channel_transport/channel_transport.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/test/channel_transport/channel_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/test/channel_transport/include/channel_transport.h View 1 chunk +0 lines, -56 lines 0 comments Download
M webrtc/test/test.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/agc/agc_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/e2e_quality/audio/audio_e2e_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/force_mic_volume_max/force_mic_volume_max.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_cpu_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_output_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_stress_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
henrikg: review henrika: root owner rubberstamp
5 years, 1 month ago (2015-11-10 17:35:31 UTC) #4
henrika_webrtc
LGTM
5 years, 1 month ago (2015-11-11 08:16:52 UTC) #5
Henrik Grunell WebRTC
lgtm https://codereview.webrtc.org/1431983006/diff/1/webrtc/test/test.gyp File webrtc/test/test.gyp (right): https://codereview.webrtc.org/1431983006/diff/1/webrtc/test/test.gyp#newcode24 webrtc/test/test.gyp:24: 'channel_transport/channel_transport.h', Nit: Fix order.
5 years, 1 month ago (2015-11-11 09:28:50 UTC) #6
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 1323fc39babb2638c5795c1e23e97c977c5c29f3 (presubmit successful).
5 years, 1 month ago (2015-11-11 09:34:42 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 09:34:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1323fc39babb2638c5795c1e23e97c977c5c29f3
Cr-Commit-Position: refs/heads/master@{#10595}

Powered by Google App Engine
This is Rietveld 408576698