Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1431283002: Reland of Work on flexible mode and screen sharing. (Closed)

Created:
5 years, 1 month ago by philipel
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Work on flexible mode and screen sharing. (patchset #1 id:1 of https://codereview.webrtc.org/1438543002/ ) Reason for revert: Failed test not related to this CL (test fails on master at an earlier date), re-landing original CL.. (This time from my @webrtc account.) Original issue's description: > Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ ) > > Reason for revert: > Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot. > > Original issue's description: > > Work on flexible mode and screen sharing. > > > > Implement VP8 style screensharing but with spatial layers. > > Implement flexible mode. > > > > Files from other patches: > > generic_encoder.cc > > layer_filtering_transport.cc > > > > BUG=webrtc:4914 > > > > Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a > > Cr-Commit-Position: refs/heads/master@{#10572} > > TBR=sprang@webrtc.org,stefan@webrtc.org,philipel@google.com,asapersson@webrtc.org,mflodman@webrtc.org,philipel@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4914 > > Committed: https://crrev.com/0be8f1d347bdb171462df89c2a4c69b3f3eb7519 > Cr-Commit-Position: refs/heads/master@{#10578} TBR=sprang@webrtc.org,stefan@webrtc.org,philipel@google.com,asapersson@webrtc.org,mflodman@webrtc.org,terelius@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4914 Committed: https://crrev.com/cfc319be1d6afec77bd41eeb70d3e7886dd524db Cr-Commit-Position: refs/heads/master@{#10581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -46 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/interface/video_codec_interface.h View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/vp9/screenshare_layers.h View 1 chunk +66 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/vp9/screenshare_layers.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/vp9/screenshare_layers_unittest.cc View 1 chunk +323 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 4 chunks +34 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 12 chunks +176 lines, -16 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state.h View 3 chunks +12 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state.cc View 6 chunks +66 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/main/source/decoding_state_unittest.cc View 1 chunk +250 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/encoded_frame.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/main/source/jitter_buffer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/video/full_stack.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 4 chunks +66 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipel
Created Reland of Work on flexible mode and screen sharing.
5 years, 1 month ago (2015-11-10 15:17:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431283002/1
5 years, 1 month ago (2015-11-10 15:17:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 15:17:27 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 15:17:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfc319be1d6afec77bd41eeb70d3e7886dd524db
Cr-Commit-Position: refs/heads/master@{#10581}

Powered by Google App Engine
This is Rietveld 408576698