|
Replace rtc::cricket::Settable with rtc::Maybe
The former is very similar to the latter, but less general (mostly in
naming).
This CL, which is the first to use Maybe at scale, also removes the implicit conversion from T to Maybe<T>, since it was agreed that the increased verbosity increased legibility.
Committed: https://crrev.com/102c6a61bc0b42dc0956d013530fc0213b7e881b
Cr-Commit-Position: refs/heads/master@{#10461}
Total comments: 11
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+450 lines, -543 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/localaudiosource.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/localaudiosource_unittest.cc
|
View
|
|
5 chunks |
+12 lines, -28 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/videosource.cc
|
View
|
1
2
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/videosource_unittest.cc
|
View
|
|
7 chunks |
+8 lines, -20 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/webrtcsession.cc
|
View
|
1
2
|
6 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/webrtcsession_unittest.cc
|
View
|
1
2
|
5 chunks |
+8 lines, -14 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/base/mediachannel.h
|
View
|
1
|
6 chunks |
+120 lines, -164 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/base/videoengine_unittest.h
|
View
|
1
2
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvideoengine2.h
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvideoengine2.cc
|
View
|
1
2
3
4
|
18 chunks |
+40 lines, -48 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvideoengine2_unittest.cc
|
View
|
1
2
3
4
|
8 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvoiceengine.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvoiceengine.cc
|
View
|
1
2
3
4
|
11 chunks |
+121 lines, -127 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/media/webrtc/webrtcvoiceengine_unittest.cc
|
View
|
1
2
|
19 chunks |
+50 lines, -48 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
talk/session/media/channel.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/maybe.h
|
View
|
1
2
|
3 chunks |
+4 lines, -15 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/maybe_unittest.cc
|
View
|
1
2
|
10 chunks |
+29 lines, -25 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/modules/audio_coding/main/acm2/rent_a_codec.h
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/modules/audio_processing/beamformer/array_util.cc
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 25 (7 generated)
|