|
|
DescriptionRemove WEBRTC_ANDROID from hardcoded gtest relative path usage.
BUG=
Committed: https://crrev.com/c21f0c04cc350142076fc4dc4723c23f311ebe81
Cr-Commit-Position: refs/heads/master@{#10501}
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
noahric@chromium.org changed reviewers: + glaznev@webrtc.org, pthatcher@webrtc.org
We can probably retire this :) I traced the history back to an early change to make talk/base build in the android source repro, and the #ifdef originally included <gtest/gtest.h>. Peter for owners, Alex to make sure android builds aren't depending on this in some way. From what I can tell, everything that wants the relative path already defines GTEST_RELATIVE_PATH.
On 2015/10/30 19:00:07, noahric wrote: > We can probably retire this :) I traced the history back to an early change to > make talk/base build in the android source repro, and the #ifdef originally > included <gtest/gtest.h>. > > Peter for owners, Alex to make sure android builds aren't depending on this in > some way. From what I can tell, everything that wants the relative path already > defines GTEST_RELATIVE_PATH. Some Android bots are red?
On 2015/10/30 20:13:47, AlexG wrote: > On 2015/10/30 19:00:07, noahric wrote: > > We can probably retire this :) I traced the history back to an early change to > > make talk/base build in the android source repro, and the #ifdef originally > > included <gtest/gtest.h>. > > > > Peter for owners, Alex to make sure android builds aren't depending on this in > > some way. From what I can tell, everything that wants the relative path > already > > defines GTEST_RELATIVE_PATH. > > Some Android bots are red? Rerun made em happy. Sounds like an interim change around non-parallel tests made them go red.
lgtm
Description was changed from ========== Remove WEBRTC_ANDROID from hardcoded gtest relative path usage. BUG= ========== to ========== Remove WEBRTC_ANDROID from hardcoded gtest relative path usage. BUG= ==========
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429693005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1495)
noahric@chromium.org changed reviewers: + mflodman@webrtc.org, tommi@webrtc.org
Added a few more OWNERS for webrtc/base. Thanks!
The CQ bit was checked by tommi@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429693005/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c21f0c04cc350142076fc4dc4723c23f311ebe81 Cr-Commit-Position: refs/heads/master@{#10501} |