Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1429693005: Remove WEBRTC_ANDROID from hardcoded gtest relative path usage. (Closed)

Created:
5 years, 1 month ago by noahric
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, phoglund
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove WEBRTC_ANDROID from hardcoded gtest relative path usage. BUG= Committed: https://crrev.com/c21f0c04cc350142076fc4dc4723c23f311ebe81 Cr-Commit-Position: refs/heads/master@{#10501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/gunit.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
noahric
We can probably retire this :) I traced the history back to an early change ...
5 years, 1 month ago (2015-10-30 19:00:07 UTC) #2
AlexG
On 2015/10/30 19:00:07, noahric wrote: > We can probably retire this :) I traced the ...
5 years, 1 month ago (2015-10-30 20:13:47 UTC) #3
noahric
On 2015/10/30 20:13:47, AlexG wrote: > On 2015/10/30 19:00:07, noahric wrote: > > We can ...
5 years, 1 month ago (2015-10-30 21:51:32 UTC) #4
AlexG
lgtm
5 years, 1 month ago (2015-10-30 21:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429693005/1
5 years, 1 month ago (2015-10-30 21:55:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1495)
5 years, 1 month ago (2015-10-30 22:02:18 UTC) #10
noahric
Added a few more OWNERS for webrtc/base. Thanks!
5 years, 1 month ago (2015-11-03 21:58:45 UTC) #12
tommi
lgtm
5 years, 1 month ago (2015-11-04 06:49:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429693005/1
5 years, 1 month ago (2015-11-04 06:49:43 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 07:47:45 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 07:47:54 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c21f0c04cc350142076fc4dc4723c23f311ebe81
Cr-Commit-Position: refs/heads/master@{#10501}

Powered by Google App Engine
This is Rietveld 408576698