Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: webrtc/base/physicalsocketserver.cc

Issue 1429513004: Switch usage of _DEBUG macro to NDEBUG. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: REBASE Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/opensslstreamadapter.cc ('k') | webrtc/base/sigslot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/physicalsocketserver.cc
diff --git a/webrtc/base/physicalsocketserver.cc b/webrtc/base/physicalsocketserver.cc
index 86abcf279b3df7ab8529b42ceb48bc13ea853e12..c3abb24d46019f2c3ac0beae9272d8ab300e9ac6 100644
--- a/webrtc/base/physicalsocketserver.cc
+++ b/webrtc/base/physicalsocketserver.cc
@@ -171,12 +171,12 @@ class PhysicalSocket : public AsyncSocket, public sigslot::has_slots<> {
sockaddr* addr = reinterpret_cast<sockaddr*>(&addr_storage);
int err = ::bind(s_, addr, static_cast<int>(len));
UpdateLastError();
-#ifdef _DEBUG
+#if !defined(NDEBUG)
if (0 == err) {
dbg_addr_ = "Bound @ ";
dbg_addr_.append(GetLocalAddress().ToString());
}
-#endif // _DEBUG
+#endif
return err;
}
@@ -361,10 +361,10 @@ class PhysicalSocket : public AsyncSocket, public sigslot::has_slots<> {
if (err == 0) {
state_ = CS_CONNECTING;
enabled_events_ |= DE_ACCEPT;
-#ifdef _DEBUG
+#if !defined(NDEBUG)
dbg_addr_ = "Listening @ ";
dbg_addr_.append(GetLocalAddress().ToString());
-#endif // _DEBUG
+#endif
}
return err;
}
@@ -549,9 +549,9 @@ class PhysicalSocket : public AsyncSocket, public sigslot::has_slots<> {
ConnState state_;
AsyncResolver* resolver_;
-#ifdef _DEBUG
+#if !defined(NDEBUG)
std::string dbg_addr_;
-#endif // _DEBUG;
+#endif
};
#if defined(WEBRTC_POSIX)
@@ -1088,10 +1088,10 @@ class SocketDispatcher : public Dispatcher, public PhysicalSocket {
if (ff != DE_CONNECT)
LOG(LS_VERBOSE) << "Signalled with DE_CONNECT: " << ff;
enabled_events_ &= ~DE_CONNECT;
-#ifdef _DEBUG
+#if !defined(NDEBUG)
dbg_addr_ = "Connected @ ";
dbg_addr_.append(GetRemoteAddress().ToString());
-#endif // _DEBUG
+#endif
SignalConnectEvent(this);
}
if (((ff & DE_ACCEPT) != 0) && (id_ == cache_id)) {
« no previous file with comments | « webrtc/base/opensslstreamadapter.cc ('k') | webrtc/base/sigslot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698