Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1429493009: Hang on android when DNS resolution is not done (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hang on android when DNS resolution is not done BUG=webrtc:5139 R=juberti@google.com TBR=juberti@webrtc.org Committed: https://crrev.com/8a4f547dadecb1ec4e1647e0ca1ad74be3048801 Cr-Commit-Position: refs/heads/master@{#10463}

Patch Set 1 #

Patch Set 2 : play around with the unit test, not check in code. #

Patch Set 3 : remove the unit test #

Patch Set 4 : add a comment and TODO #

Patch Set 5 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/p2p/base/stunport.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
guoweis_webrtc
I was playing around with a unit test but since android trybot doesn't run rtc_unittests, ...
5 years, 1 month ago (2015-10-29 22:36:02 UTC) #2
juberti
lgtm otherwise
5 years, 1 month ago (2015-10-30 01:19:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429493009/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429493009/80001
5 years, 1 month ago (2015-10-30 16:03:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1485)
5 years, 1 month ago (2015-10-30 16:11:05 UTC) #10
guoweis_webrtc
Committed patchset #5 (id:80001) manually as 8a4f547dadecb1ec4e1647e0ca1ad74be3048801 (presubmit successful).
5 years, 1 month ago (2015-10-30 16:12:50 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:12:57 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8a4f547dadecb1ec4e1647e0ca1ad74be3048801
Cr-Commit-Position: refs/heads/master@{#10463}

Powered by Google App Engine
This is Rietveld 408576698