Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1429053002: Make ConnectionType public in order to add java NetworkObserver. (Closed)

Created:
5 years, 1 month ago by honghaiz3
Modified:
5 years, 1 month ago
Reviewers:
AlexG, pthatcher1, jiayl2, jiayl1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make ConnectionType public in order to add java NetworkObserver. BUG= R=glaznev@webrtc.org, jiayl@google.com Committed: https://crrev.com/5a846c086bdf714c9b8ca55bb1e93b04517cc06a Cr-Commit-Position: refs/heads/master@{#10485}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
honghaiz3
5 years, 1 month ago (2015-11-02 04:16:53 UTC) #2
jiayl1
lgtm
5 years, 1 month ago (2015-11-02 19:08:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429053002/20001
5 years, 1 month ago (2015-11-02 19:12:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1526)
5 years, 1 month ago (2015-11-02 19:14:59 UTC) #11
AlexG
lgtm
5 years, 1 month ago (2015-11-02 19:31:59 UTC) #13
honghaiz3
Committed patchset #1 (id:20001) manually as 5a846c086bdf714c9b8ca55bb1e93b04517cc06a (presubmit successful).
5 years, 1 month ago (2015-11-02 19:33:35 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 19:33:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a846c086bdf714c9b8ca55bb1e93b04517cc06a
Cr-Commit-Position: refs/heads/master@{#10485}

Powered by Google App Engine
This is Rietveld 408576698