Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1428613004: Revert of Prevent Opus DTX from generating intermittent noise during silence (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Prevent Opus DTX from generating intermittent noise during silence (patchset #10 id:250001 of https://codereview.webrtc.org/1415173005/ ) Reason for revert: Breaks voe_auto_test on all three "large tests bots". https://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/5630/steps/voe_auto_test/logs/stdio https://build.chromium.org/p/client.webrtc/builders/Mac32%20Release%20%5Blarge%20tests%5D/builds/5599/steps/voe_auto_test/logs/stdio https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%5Blarge%20tests%5D/builds/5645/steps/voe_auto_test/logs/stdio Notice these bots are no longer a part of the default trybot set, so they have to be run manually when working with code that affects their tests (they were removed as they queued up all the time in the CQ, and usually don't catch breakages). Original issue's description: > Prevent Opus DTX from generating intermittent noise during silence. > > Opus may have an internal error that causes this. Here we make a workaround by adding some small disturbance to the input signals to break a long sequence of zeros. > > BUG=webrtc:5127 > > Committed: https://crrev.com/f475add57eada116bc960fe2935876ec8c077977 > Cr-Commit-Position: refs/heads/master@{#10565} TBR=tina.legrand@webrtc.org,kwiberg@webrtc.org,solenberg@webrtc.org,minyue@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5127 Committed: https://crrev.com/b4a753fdb5725e1b241c6c40cc2a752e57cfbdcb Cr-Commit-Position: refs/heads/master@{#10567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -375 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_inst.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 3 chunks +33 lines, -76 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 10 chunks +32 lines, -84 lines 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/voe_output_test.cc View 1 chunk +0 lines, -198 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_webrtc
Created Revert of Prevent Opus DTX from generating intermittent noise during silence
5 years, 1 month ago (2015-11-09 21:26:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428613004/1
5 years, 1 month ago (2015-11-09 21:26:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 21:27:07 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:27:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4a753fdb5725e1b241c6c40cc2a752e57cfbdcb
Cr-Commit-Position: refs/heads/master@{#10567}

Powered by Google App Engine
This is Rietveld 408576698