Utilize bitrate above codec max to protect video.

Utilize bitrate above codec max to protect video.

When estimating that we can send more than the codec max bitrate (under
the assumption that codec max bitrate is good enough for the quality),
we should use additional bitrate so that we can maintain good quality.

Global bitrate caps should still be enforced through bitrate caps (b=AS)
and not codec max bitrates.

BUG=webrtc:5102
R=stefan@webrtc.org

Committed: https://crrev.com/7367463acc8ca01c2d70ae39408951339b2d7b3d
Cr-Commit-Position: refs/heads/master@{#10457}

[pbos-webrtc, 2015-10-26 19:42:33]

PTAL woo

[pbos-webrtc, 2015-10-26 19:42:38]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 19:42:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428473002/1

[commit-bot: I haz the power, 2015-10-26 19:53:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 19:53:07]

Dry run: Try jobs failed on following builders:
  win_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/716)

[pbos-webrtc, 2015-10-26 20:13:51]

I bet this is what windows had problems with. :(

[pbos-webrtc, 2015-10-26 20:14:05]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 20:14:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428473002/20001

[commit-bot: I haz the power, 2015-10-26 22:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 22:14:16]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2015-10-29 07:11:16]

lgtm

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/main/source/media_optimization.cc (right):

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:275: // go above
50% with FEC maxed out.
I don't think it does. Please remove.

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:287:
printf("protection_overhead_bps: %f\n", protection_overhead_rate);
Please remove!

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:288:
target_bit_rate_ = target_bitrate * (1.0 - protection_overhead_rate);
Name this video_target_bitrate_

[pbos-webrtc, 2015-10-29 16:40:35]

rebase + feedback

[pbos-webrtc, 2015-10-29 16:40:42]

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/main/source/media_optimization.cc (right):

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:275: // go above
50% with FEC maxed out.
On 2015/10/29 07:11:15, stefan-webrtc (holmer) wrote:
> I don't think it does. Please remove.

Done.

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:287:
printf("protection_overhead_bps: %f\n", protection_overhead_rate);
On 2015/10/29 07:11:15, stefan-webrtc (holmer) wrote:
> Please remove!

Done.

https://codereview.webrtc.org/1428473002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/main/source/media_optimization.cc:288:
target_bit_rate_ = target_bitrate * (1.0 - protection_overhead_rate);
On 2015/10/29 07:11:15, stefan-webrtc (holmer) wrote:
> Name this video_target_bitrate_

Done.

[pbos-webrtc, 2015-10-29 16:40:46]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2015-10-29 16:40:46]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1428473002/#ps40001 (title:
"rebase + feedback")

[commit-bot: I haz the power, 2015-10-29 16:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428473002/40001

[commit-bot: I haz the power, 2015-10-29 18:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:41:10]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2015-10-29 22:40:46]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-10-29 22:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428473002/40001

[commit-bot: I haz the power, 2015-10-29 22:45:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-29 22:45:14]

Patchset 3 (id:??) landed as
https://crrev.com/7367463acc8ca01c2d70ae39408951339b2d7b3d
Cr-Commit-Position: refs/heads/master@{#10457}