Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1428433002: Rewrote perform_action_on_all_files to be parallell. (Closed)

Created:
5 years, 1 month ago by phoglund
Modified:
5 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rewrote perform_action_on_all_files to be parallell. This speeds up decode for a 720p workload from 25s to 5s on my machine. I did some benchmarking and it appears we spend the vast majority of the time on zxing decoding, so now we will bring all processors on the the machine to bear. BUG=webrtc:4986 Committed: https://crrev.com/be81fa538d915542c0be7a304398aa60b4e3de67 Cr-Commit-Position: refs/heads/master@{#10443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M webrtc/tools/barcode_tools/helper_functions.py View 3 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund
5 years, 1 month ago (2015-10-26 15:50:31 UTC) #2
kjellander_webrtc
lgtm, awesome!
5 years, 1 month ago (2015-10-28 17:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428433002/1
5 years, 1 month ago (2015-10-29 08:14:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 09:22:50 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 09:22:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be81fa538d915542c0be7a304398aa60b4e3de67
Cr-Commit-Position: refs/heads/master@{#10443}

Powered by Google App Engine
This is Rietveld 408576698