Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: webrtc/video_decoder.h

Issue 1428293003: Add VideoCodec::PreferDecodeLate (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Also renamed method in generic_decoder. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_decoder.h
diff --git a/webrtc/video_decoder.h b/webrtc/video_decoder.h
index 3d0410429fb21af8911e516bdecc3888a871f2de..013622a8ae781f4aeb98adcdec5c99b1a6429d83 100644
--- a/webrtc/video_decoder.h
+++ b/webrtc/video_decoder.h
@@ -73,6 +73,13 @@ class VideoDecoder {
virtual int32_t Release() = 0;
virtual int32_t Reset() = 0;
+
+ // Returns true if the decoder prefer to decode frames late.
+ // That is, it can not decode infinite number of frames before the decoded
+ // frame is consumed.
+ virtual bool PreferDecodeLate() const {
+ return true;
stefan-webrtc 2015/12/07 09:02:19 Shouldn't the default be false? Or do you want to
perkj_webrtc 2015/12/07 12:06:34 I would prefer to not change the current behavior.
+ }
};
// Class used to wrap external VideoDecoders to provide a fallback option on
@@ -97,6 +104,7 @@ class VideoDecoderSoftwareFallbackWrapper : public webrtc::VideoDecoder {
int32_t Release() override;
int32_t Reset() override;
+ bool PreferDecodeLate() const override;
private:
bool InitFallbackDecoder();

Powered by Google App Engine
This is Rietveld 408576698