Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: talk/app/webrtc/rtpsender.h

Issue 1428243005: Fix for scenario where m-line is revived after being set to port 0. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/rtpsender.h
diff --git a/talk/app/webrtc/rtpsender.h b/talk/app/webrtc/rtpsender.h
index 374190932325bb9715ed4b477b61556177833935..bc693e9fc9f03f5415c1147fc436a667df6426a9 100644
--- a/talk/app/webrtc/rtpsender.h
+++ b/talk/app/webrtc/rtpsender.h
@@ -85,13 +85,17 @@ class AudioRtpSender : public ObserverInterface,
return track_.get();
}
+ cricket::MediaType media_type() const override {
+ return cricket::MEDIA_TYPE_AUDIO;
+ }
+
std::string id() const override { return id_; }
void Stop() override;
- private:
- void Reconfigure();
+ void Reconfigure() override;
+ private:
std::string id_;
rtc::scoped_refptr<AudioTrackInterface> track_;
uint32_t ssrc_;
@@ -121,12 +125,20 @@ class VideoRtpSender : public ObserverInterface,
return track_.get();
}
+ cricket::MediaType media_type() const override {
+ return cricket::MEDIA_TYPE_VIDEO;
+ }
+
std::string id() const override { return id_; }
void Stop() override;
+ // Calls SetCaptureDevice and SetVideoSend.
+ void Reconfigure() override;
+
private:
- void Reconfigure();
+ // Only calls SetVideoSend.
pthatcher1 2015/11/11 00:45:02 Perhaps this would be more clear as "Only calls Vi
Taylor Brandstetter 2015/11/11 01:33:30 Done.
+ void SetVideoSend();
std::string id_;
rtc::scoped_refptr<VideoTrackInterface> track_;

Powered by Google App Engine
This is Rietveld 408576698