Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Side by Side Diff: talk/app/webrtc/rtpreceiverinterface.h

Issue 1428243005: Fix for scenario where m-line is revived after being set to port 0. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 17 matching lines...) Expand all
28 // This file contains interfaces for RtpReceivers 28 // This file contains interfaces for RtpReceivers
29 // http://w3c.github.io/webrtc-pc/#rtcrtpreceiver-interface 29 // http://w3c.github.io/webrtc-pc/#rtcrtpreceiver-interface
30 30
31 #ifndef TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_ 31 #ifndef TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_
32 #define TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_ 32 #define TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_
33 33
34 #include <string> 34 #include <string>
35 35
36 #include "talk/app/webrtc/proxy.h" 36 #include "talk/app/webrtc/proxy.h"
37 #include "talk/app/webrtc/mediastreaminterface.h" 37 #include "talk/app/webrtc/mediastreaminterface.h"
38 #include "talk/session/media/mediasession.h"
38 #include "webrtc/base/refcount.h" 39 #include "webrtc/base/refcount.h"
39 #include "webrtc/base/scoped_ref_ptr.h" 40 #include "webrtc/base/scoped_ref_ptr.h"
40 41
41 namespace webrtc { 42 namespace webrtc {
42 43
43 class RtpReceiverInterface : public rtc::RefCountInterface { 44 class RtpReceiverInterface : public rtc::RefCountInterface {
44 public: 45 public:
45 virtual rtc::scoped_refptr<MediaStreamTrackInterface> track() const = 0; 46 virtual rtc::scoped_refptr<MediaStreamTrackInterface> track() const = 0;
46 47
48 // Audio or video?
49 virtual cricket::MediaType media_type() const = 0;
50
47 // Not to be confused with "mid", this is a field we can temporarily use 51 // Not to be confused with "mid", this is a field we can temporarily use
48 // to uniquely identify a receiver until we implement Unified Plan SDP. 52 // to uniquely identify a receiver until we implement Unified Plan SDP.
49 virtual std::string id() const = 0; 53 virtual std::string id() const = 0;
50 54
51 virtual void Stop() = 0; 55 virtual void Stop() = 0;
52 56
57 virtual void Reconfigure() = 0;
pthatcher1 2015/11/11 00:45:02 Can you add a comment describing what effect this
Taylor Brandstetter 2015/11/11 01:33:30 Done. Just to note, I'm planning to move this meth
58
53 protected: 59 protected:
54 virtual ~RtpReceiverInterface() {} 60 virtual ~RtpReceiverInterface() {}
55 }; 61 };
56 62
57 // Define proxy for RtpReceiverInterface. 63 // Define proxy for RtpReceiverInterface.
58 BEGIN_PROXY_MAP(RtpReceiver) 64 BEGIN_PROXY_MAP(RtpReceiver)
59 PROXY_CONSTMETHOD0(rtc::scoped_refptr<MediaStreamTrackInterface>, track) 65 PROXY_CONSTMETHOD0(rtc::scoped_refptr<MediaStreamTrackInterface>, track)
66 PROXY_CONSTMETHOD0(cricket::MediaType, media_type)
60 PROXY_CONSTMETHOD0(std::string, id) 67 PROXY_CONSTMETHOD0(std::string, id)
61 PROXY_METHOD0(void, Stop) 68 PROXY_METHOD0(void, Stop)
69 PROXY_METHOD0(void, Reconfigure)
62 END_PROXY() 70 END_PROXY()
63 71
64 } // namespace webrtc 72 } // namespace webrtc
65 73
66 #endif // TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_ 74 #endif // TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698