Re-enable PCAP reading in neteq_rtpplay

Re-enable PCAP reading in neteq_rtpplay

Reading of PCAP (Wireshark) files was not possible due to a bug in the
parsing of files. This change fixes that by adding new validator methods
to RtpFileSource that can be used to determine the input file type.

R=ivoc@webrtc.org

Committed: https://crrev.com/5eb9d578839e502e989615186b800d9d1074ea99
Cr-Commit-Position: refs/heads/master@{#10490}

[hlundin-webrtc, 2015-10-30 09:59:52]

Ivo,

Please, take a look.

Thanks!

[ivoc, 2015-11-02 15:27:09]

Nice, I like your approach better than the previous one. LGTM with one question.

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right):

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:38: return
!!temp_file;
I have a hard time understanding the !!, is there some alternative that might be
easier to understand for mere mortals like myself? :-)

[hlundin-webrtc, 2015-11-02 15:41:21]

henrik.lundin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[hlundin-webrtc, 2015-11-02 15:41:21]

+kwiberg@, see inline question.

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right):

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:38: return
!!temp_file;
On 2015/11/02 15:27:09, ivoc wrote:
> I have a hard time understanding the !!, is there some alternative that might
be
> easier to understand for mere mortals like myself? :-)

I blame kwiberg for recruiting me to the dark side. I'll let him be the arbiter.

[kwiberg-webrtc, 2015-11-02 19:25:00]

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right):

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:38: return
!!temp_file;
On 2015/11/02 15:41:21, hlundin-webrtc wrote:
> On 2015/11/02 15:27:09, ivoc wrote:
> > I have a hard time understanding the !!, is there some alternative that
might
> be
> > easier to understand for mere mortals like myself? :-)
> 
> I blame kwiberg for recruiting me to the dark side. I'll let him be the
arbiter.

!x is true if x is false, false if x is true. So !!x is false if x is false,
true if x is true. Basically, it's a shorter way to write static_cast<bool>(x).

If you feel that it's too short, note that any even number of exclamation marks
will do.

[hlundin-webrtc, 2015-11-03 06:44:41]

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc (right):

https://codereview.webrtc.org/1427923003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc:38: return
!!temp_file;
On 2015/11/02 19:24:59, kwiberg-webrtc wrote:
> On 2015/11/02 15:41:21, hlundin-webrtc wrote:
> > On 2015/11/02 15:27:09, ivoc wrote:
> > > I have a hard time understanding the !!, is there some alternative that
> might
> > be
> > > easier to understand for mere mortals like myself? :-)
> > 
> > I blame kwiberg for recruiting me to the dark side. I'll let him be the
> arbiter.
> 
> !x is true if x is false, false if x is true. So !!x is false if x is false,
> true if x is true. Basically, it's a shorter way to write
static_cast<bool>(x).
> 
> If you feel that it's too short, note that any even number of exclamation
marks
> will do.

Thanks for providing that invaluable truth table.

I feel that !!temp_file is more attractable than static_cast<bool>(temp_file).

[hlundin-webrtc, 2015-11-03 06:44:45]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2015-11-03 06:44:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427923003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427923003/1

[commit-bot: I haz the power, 2015-11-03 08:32:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-03 08:32:23]

Patchset 1 (id:??) landed as
https://crrev.com/5eb9d578839e502e989615186b800d9d1074ea99
Cr-Commit-Position: refs/heads/master@{#10490}