Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1427653007:
Remove packet initializer in RtpRtcpRtxNackTest. (Closed)
|
Created:
5 years, 1 month ago by pbos-webrtc Modified:
5 years, 1 month ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove packet initializer in RtpRtcpRtxNackTest.
Fixes RtpRtcpRtxNackTest to not use uninitialized data when not sending
RTX.
BUG=webrtc:3183
R=stefan@webrtc.org
Committed: https://crrev.com/740c4f11e0d3b409c5444b328859754d2a717e33
Cr-Commit-Position: refs/heads/master@{#10665}
Patch Set 1 #Patch Set 2 : potential fix (but wtf) #Messages
Total messages: 20 (9 generated)
The CQ bit was checked by pbos@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653007/1
Description was changed from ========== Remove packet initializer RtpRtcpRtxNackTest. This used to hide a bug, but it doesn't seem present anymore. BUG=webrtc:3183 R=stefan@webrtc.org ========== to ========== Remove packet initializer in RtpRtcpRtxNackTest. This used to hide a bug, but it doesn't seem present anymore. BUG=webrtc:3183 R=stefan@webrtc.org ==========
The CQ bit was unchecked by pbos@webrtc.org
The CQ bit was checked by pbos@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653007/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
potential fix (but wtf)
The CQ bit was checked by pbos@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653007/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove packet initializer in RtpRtcpRtxNackTest. This used to hide a bug, but it doesn't seem present anymore. BUG=webrtc:3183 R=stefan@webrtc.org ========== to ========== Remove packet initializer in RtpRtcpRtxNackTest. Fixes RtpRtcpRtxNackTest to not use uninitialized data when not sending RTX. BUG=webrtc:3183 R=stefan@webrtc.org ==========
PTAL stefan, this removes the error in DrMemory full, but I think it's timing dependent on whether we actually send non-RTX here? I couldn't get the bug to trigger under valgrind even when replacing the stack allocation with an explicit malloc.
lgtm
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653007/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/740c4f11e0d3b409c5444b328859754d2a717e33 Cr-Commit-Position: refs/heads/master@{#10665} |
