Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1427253002: Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile. (Closed)

Created:
5 years, 1 month ago by åsapersson
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile. Max p_diff is 8 bits. Change type of number of reference pictures (size_t -> uint8_t). Max is 2 bits. Size of WebRtcRTPHeader: 4352 -> 1784 bytes. BUG=webrtc:5144 Committed: https://crrev.com/81c5c7f8157f767747bd97419eb0a589207354cf Cr-Commit-Position: refs/heads/master@{#10504}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : also update include/module_common_types.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/interface/module_common_types.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/main/source/jitter_buffer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/session_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
åsapersson
5 years, 1 month ago (2015-11-02 13:23:55 UTC) #4
mflodman
LGTM
5 years, 1 month ago (2015-11-04 08:17:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427253002/20001
5 years, 1 month ago (2015-11-04 08:32:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/7753)
5 years, 1 month ago (2015-11-04 08:42:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427253002/40001
5 years, 1 month ago (2015-11-04 09:25:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-04 10:19:44 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/81c5c7f8157f767747bd97419eb0a589207354cf Cr-Commit-Position: refs/heads/master@{#10504}
5 years, 1 month ago (2015-11-04 10:19:52 UTC) #15
åsapersson
5 years, 1 month ago (2015-11-04 15:40:20 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1423493005/ by asapersson@webrtc.org.

The reason for reverting is: Breaks bot..

Powered by Google App Engine
This is Rietveld 408576698