Remove redudant encoder rate calls.

Remove redudant encoder rate calls.

Moves EncoderParameters update checks into GenericEncoder before calling
SetRates/SetChannelParameters as applicable.

Also removes CodecConfigParameters as a bonus.

BUG=
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/69ccb331310fff13a8b061c294d82b20f2b82bc7
Cr-Commit-Position: refs/heads/master@{#10452}

[pbos-webrtc, 2015-10-29 13:36:46]

PTAL woo

[pbos-webrtc, 2015-10-29 13:36:50]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 13:36:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426953003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426953003/1

[pbos-webrtc, 2015-10-29 13:38:58]

Description was changed from

==========
Remove redudant encoder rate calls.

Moves EncoderParameters update checks into GenericEncoder before calling
SetRates/SetChannelParameters as applicable.

Also removes CodecConfigParameters as a bonus.

BUG=
R=stefan@webrtc.org
==========

to

==========
Remove redudant encoder rate calls.

Moves EncoderParameters update checks into GenericEncoder before calling
SetRates/SetChannelParameters as applicable.

Also removes CodecConfigParameters as a bonus.

BUG=
R=stefan@webrtc.org
==========

[stefan-webrtc, 2015-10-29 14:12:06]

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.cc (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:97:
encoder_params_({0,0,0,0}),
spaces between elements.

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.h (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.h:120: // TODO(tommi):
We could replace BitRate and FrameRate below with a GetRates
GetEncoderParameters would make more sense then, wouldn't it? And that you have
already added it seems.

[pbos-webrtc, 2015-10-29 14:35:48]

cl format + feedback

[pbos-webrtc, 2015-10-29 14:37:33]

PTAL

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.cc (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:97:
encoder_params_({0,0,0,0}),
On 2015/10/29 14:12:06, stefan-webrtc (holmer) wrote:
> spaces between elements.

cl-format done.

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.h (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.h:120: // TODO(tommi):
We could replace BitRate and FrameRate below with a GetRates
On 2015/10/29 14:12:06, stefan-webrtc (holmer) wrote:
> GetEncoderParameters would make more sense then, wouldn't it? And that you
have
> already added it seems.

Yep, done. Note that there's no caller who does uses both of them directly, so
this has no direct impact.

[stefan-webrtc, 2015-10-29 14:50:23]

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.h (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.h:120: // TODO(tommi):
We could replace BitRate and FrameRate below with a GetRates
On 2015/10/29 14:37:33, pbos-webrtc wrote:
> On 2015/10/29 14:12:06, stefan-webrtc (holmer) wrote:
> > GetEncoderParameters would make more sense then, wouldn't it? And that you
> have
> > already added it seems.
> 
> Yep, done. Note that there's no caller who does uses both of them directly, so
> this has no direct impact.

But don't you have two methods for this now? Line 122 and line 120

[pbos-webrtc, 2015-10-29 14:52:39]

remove redundant function

[pbos-webrtc, 2015-10-29 15:26:02]

PTAL

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.h (right):

https://codereview.webrtc.org/1426953003/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.h:120: // TODO(tommi):
We could replace BitRate and FrameRate below with a GetRates
On 2015/10/29 14:50:22, stefan-webrtc (holmer) wrote:
> On 2015/10/29 14:37:33, pbos-webrtc wrote:
> > On 2015/10/29 14:12:06, stefan-webrtc (holmer) wrote:
> > > GetEncoderParameters would make more sense then, wouldn't it? And that you
> > have
> > > already added it seems.
> > 
> > Yep, done. Note that there's no caller who does uses both of them directly,
so
> > this has no direct impact.
> 
> But don't you have two methods for this now? Line 122 and line 120

Brain fart, thanks, done. :)

[stefan-webrtc, 2015-10-29 15:28:50]

lgtm

[pbos-webrtc, 2015-10-29 15:30:06]

Description was changed from

==========
Remove redudant encoder rate calls.

Moves EncoderParameters update checks into GenericEncoder before calling
SetRates/SetChannelParameters as applicable.

Also removes CodecConfigParameters as a bonus.

BUG=
R=stefan@webrtc.org
==========

to

==========
Remove redudant encoder rate calls.

Moves EncoderParameters update checks into GenericEncoder before calling
SetRates/SetChannelParameters as applicable.

Also removes CodecConfigParameters as a bonus.

BUG=
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

[pbos-webrtc, 2015-10-29 15:30:06]

pbos@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[pbos-webrtc, 2015-10-29 15:30:18]

TBR=mflodman@ for: webrtc/video_encoder.h

[pbos-webrtc, 2015-10-29 15:30:37]

Committed patchset #3 (id:40001) manually as
69ccb331310fff13a8b061c294d82b20f2b82bc7 (presubmit successful).

[commit-bot: I haz the power, 2015-10-29 15:30:39]

Patchset 3 (id:??) landed as
https://crrev.com/69ccb331310fff13a8b061c294d82b20f2b82bc7
Cr-Commit-Position: refs/heads/master@{#10452}