Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1426883002: pass clangcl compile options to ignore warnings in gflags.cc (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
ajm, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

pass clangcl compile options to ignore warnings in gflags.cc R=kjellander@webrtc.org, ajm@webrtc.org BUG=webrtc:760 Committed: https://crrev.com/b608eb865e9fa0c9e3e78f1ff036341622ee7819 Cr-Commit-Position: refs/heads/master@{#10440}

Patch Set 1 #

Total comments: 1

Patch Set 2 : check for clang and windows for doing clangcl options #

Patch Set 3 : remove libyuv comment and move webrtc comment to top #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/gflags/gflags.gyp View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
fbarchard1
5 years, 1 month ago (2015-10-28 00:29:04 UTC) #1
kjellander_webrtc
Generally looks good but you have to make the newly added code only apply when ...
5 years, 1 month ago (2015-10-28 12:09:01 UTC) #3
kjellander_webrtc
lgtm no need to run all those trybots for this patch (as we're kind of ...
5 years, 1 month ago (2015-10-28 17:54:58 UTC) #4
fbarchard1
Committed patchset #3 (id:40001) manually as b608eb865e9fa0c9e3e78f1ff036341622ee7819 (presubmit successful).
5 years, 1 month ago (2015-10-28 17:59:54 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 17:59:56 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b608eb865e9fa0c9e3e78f1ff036341622ee7819
Cr-Commit-Position: refs/heads/master@{#10440}

Powered by Google App Engine
This is Rietveld 408576698