Add stats for used video codec type for a sent video stream:

Add stats for used video codec type for a sent video stream:

- "WebRTC.Video.Encoder.CodecType"

BUG=chromium:512752
Committed: https://crrev.com/2a0a2a410f36b85fdc184d53b6992f4ba1a43b60
Cr-Commit-Position: refs/heads/master@{#10423}

[åsapersson, 2015-10-26 11:28:17]

Description was changed from

==========
Add stats for used video codec type for a sent video stream:

- "WebRTC.Video.Encoder.CodecType"


BUG=chromium:512752
==========

to

==========
Add stats for used video codec type for a sent video stream:

- "WebRTC.Video.Encoder.CodecType"


BUG=chromium:512752
==========

[åsapersson, 2015-10-26 11:28:17]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2015-10-26 13:19:03]

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
webrtc/video/send_statistics_proxy.cc:26: kVideoVp8 = 0,
I'd prefer unknown to be zero, and then set explicit values for VP9 and H264 as
well, so that we don't risk that they change.

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
webrtc/video/send_statistics_proxy.cc:30: kVideoMax = 20,
I think you can pick something larger if this isn't supposed to change, like 64.
It shouldn't matter either way.

[åsapersson, 2015-10-26 14:19:53]

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
webrtc/video/send_statistics_proxy.cc:26: kVideoVp8 = 0,
On 2015/10/26 13:19:03, pbos-webrtc wrote:
> I'd prefer unknown to be zero, and then set explicit values for VP9 and H264
as
> well, so that we don't risk that they change.

Done.

https://codereview.webrtc.org/1426673002/diff/1/webrtc/video/send_statistics_...
webrtc/video/send_statistics_proxy.cc:30: kVideoMax = 20,
On 2015/10/26 13:19:03, pbos-webrtc wrote:
> I think you can pick something larger if this isn't supposed to change, like
64.
> It shouldn't matter either way.

Done.

[pbos-webrtc, 2015-10-26 14:22:08]

lgtm

[åsapersson, 2015-10-27 07:37:42]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2015-10-27 07:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426673002/20001

[commit-bot: I haz the power, 2015-10-27 08:32:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-27 08:32:14]

Patchset 2 (id:??) landed as
https://crrev.com/2a0a2a410f36b85fdc184d53b6992f4ba1a43b60
Cr-Commit-Position: refs/heads/master@{#10423}